Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2566533002: Bump up scaling limit for MediaCodec. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Bump up scaling limit for MediaCodec. Wait until MediaCodec is better tested at these low resolutions, and until some fallback mechanism is in place before lowering this threshold. BUG=webrtc:6837 Committed: https://crrev.com/3e9b1330467edf6b5af609b375c15efb9e6b4933 Cr-Commit-Position: refs/heads/master@{#15498}

Patch Set 1 #

Patch Set 2 : update unittests #

Patch Set 3 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M webrtc/video/vie_encoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
kthelgason
Henrik, PTAL. Short and sweet :)
4 years ago (2016-12-08 22:22:43 UTC) #2
henrika_webrtc
Indeed ;-) But given that I don't know the code, please check with magjed@ Thanks!
4 years ago (2016-12-09 09:10:08 UTC) #11
magjed_webrtc
lgtm
4 years ago (2016-12-09 09:17:49 UTC) #12
henrika_webrtc
LGTM
4 years ago (2016-12-09 09:29:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2566533002/40001
4 years ago (2016-12-09 09:32:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 09:46:45 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3e9b1330467edf6b5af609b375c15efb9e6b4933 Cr-Commit-Position: refs/heads/master@{#15498}
4 years ago (2016-12-09 09:46:53 UTC) #20
kthelgason
4 years ago (2016-12-09 10:30:31 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2562963002/ by kthelgason@webrtc.org.

The reason for reverting is: Failed on the perf tests..

Powered by Google App Engine
This is Rietveld 408576698