Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2566383003: VP8DecoderImpl: Fix uninitialized memory crash (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
tommi, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/branch-heads/56
Project:
webrtc
Visibility:
Public.

Description

VP8DecoderImpl: Fix uninitialized memory crash It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed, because the |decoder_| memory will be uninitialized. See the bug for more info. BUG=chromium:663293 TBR=mflodman,tommi Committed: https://chromium.googlesource.com/external/webrtc/+/ac061a9ab6ca6690acb6284c1ee34860927acfd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
magjed_webrtc
4 years ago (2016-12-13 10:52:51 UTC) #4
magjed_webrtc
Committed patchset #1 (id:1) manually as ac061a9ab6ca6690acb6284c1ee34860927acfd7 (presubmit successful).
4 years ago (2016-12-13 10:53:43 UTC) #6
tommi
lgtm
4 years ago (2016-12-13 11:04:39 UTC) #7
mflodman
4 years ago (2016-12-14 08:12:45 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698