Issue 2565693002: [OLD] Change sequence checker to lock in FlexfecSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2565693002: [OLD] Change sequence checker to lock in FlexfecSender. (Closed)

Created:
4 years ago by brandtr

Modified:
4 years ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Change sequence checker to lock in FlexfecSender. Some Android devices have multithreaded encoders. BUG=webrtc:5654

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	webrtc/modules/rtp_rtcp/include/flexfec_sender.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
	M	webrtc/modules/rtp_rtcp/source/flexfec_sender.cc	View		3 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2565693002/1

4 years ago (2016-12-09 08:57:48 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years ago (2016-12-09 09:20:18 UTC) #3

brandtr

4 years ago (2016-12-09 13:11:46 UTC) #5

Description was changed from

==========
Change sequence checker to lock in FlexfecSender.

Some Android devices have multithreaded encoders.

BUG=webrtc:5654
==========

to

==========
Change sequence checker to lock in FlexfecSender.

Some Android devices have multithreaded encoders.

BUG=webrtc:5654
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages