Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: webrtc/modules/rtp_rtcp/include/flexfec_sender.h

Issue 2562983002: Remove sequenced task checker from FlexfecSender. (Closed)
Patch Set: Move test to https://codereview.webrtc.org/2573453002/ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/flexfec_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/include/flexfec_sender.h
diff --git a/webrtc/modules/rtp_rtcp/include/flexfec_sender.h b/webrtc/modules/rtp_rtcp/include/flexfec_sender.h
index 48d3da02ac2487e1197ffdd41c226c2ca3a2ef5a..fa4bd6e7eca1a08391aaa204ee68d699c77b2359 100644
--- a/webrtc/modules/rtp_rtcp/include/flexfec_sender.h
+++ b/webrtc/modules/rtp_rtcp/include/flexfec_sender.h
@@ -29,6 +29,9 @@ namespace webrtc {
class RtpPacketToSend;
+// Note that this class is not thread safe, and thus requires external
+// synchronization.
+
class FlexfecSender {
public:
FlexfecSender(int payload_type,
@@ -62,9 +65,8 @@ class FlexfecSender {
private:
// Utility.
Clock* const clock_;
- Random random_ GUARDED_BY(sequence_checker_);
- int64_t last_generated_packet_ms_ GUARDED_BY(sequence_checker_);
- rtc::SequencedTaskChecker sequence_checker_;
+ Random random_;
+ int64_t last_generated_packet_ms_;
// Config.
const int payload_type_;
@@ -72,10 +74,10 @@ class FlexfecSender {
const uint32_t ssrc_;
const uint32_t protected_media_ssrc_;
// Sequence number of next packet to generate.
- uint16_t seq_num_ GUARDED_BY(sequence_checker_);
+ uint16_t seq_num_;
// Implementation.
- UlpfecGenerator ulpfec_generator_ GUARDED_BY(sequence_checker_);
+ UlpfecGenerator ulpfec_generator_;
const RtpHeaderExtensionMap rtp_header_extension_map_;
};
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/flexfec_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698