Add an optional artificial nearend signal for aecdump call recreation

webrtc/modules/audio_processing/test/aec_dump_based_simulator.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 12 matching lines @@
 #include "webrtc/modules/audio_processing/debug.pb.h"
 #endif
 RTC_POP_IGNORING_WUNDEF()
 
 namespace webrtc {
 namespace test {
 
 // Used to perform an audio processing simulation from an aec dump.
 class AecDumpBasedSimulator final : public AudioProcessingSimulator {
  public:
-  explicit AecDumpBasedSimulator(const SimulationSettings& settings)
-      : AudioProcessingSimulator(settings) {}
-  ~AecDumpBasedSimulator() override {}
+  explicit AecDumpBasedSimulator(const SimulationSettings& settings);
+  ~AecDumpBasedSimulator() override;
 
   // Processes the messages in the aecdump file.
   void Process() override;
 
  private:
   void HandleMessage(const webrtc::audioproc::Init& msg);
   void HandleMessage(const webrtc::audioproc::Stream& msg);
   void HandleMessage(const webrtc::audioproc::ReverseStream& msg);
   void HandleMessage(const webrtc::audioproc::Config& msg);
   void PrepareProcessStreamCall(const webrtc::audioproc::Stream& msg,
                                 bool* set_stream_analog_level_called);
   void PrepareReverseProcessStreamCall(
       const webrtc::audioproc::ReverseStream& msg);
   void VerifyProcessStreamBitExactness(const webrtc::audioproc::Stream& msg);
 
   enum InterfaceType {
     kFixedInterface,
     kFloatInterface,
     kNotSpecified,
   };
 
   FILE* dump_input_file_;
+  std::unique_ptr<WavReader> artificial_nearend_file_;

[ivoc, 2016/12/08 10:55:19]

I think this can be removed, it does not seem to be used anywhere.

[peah-webrtc, 2016/12/08 12:02:26]

Good find!
Done.

+  std::unique_ptr<ChannelBufferWavReader> artificial_nearend_buffer_reader_;

[ivoc, 2016/12/08 10:55:19]

This can be removed as well right? The same member is part of
AudioProcessingSimulator, from which this class derives.

[peah-webrtc, 2016/12/08 12:02:26]

Good find!
Done.

   InterfaceType interface_used_ = InterfaceType::kNotSpecified;
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(AecDumpBasedSimulator);
 };
 
 }  // namespace test
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_TEST_AEC_DUMP_BASED_SIMULATOR_H_