Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2907)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc

Issue 2559953002: Log audio network adapter decisions in event log. (Closed)
Patch Set: Log Ana Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc
index a9922b0987bafc9cf04c6b8bf836384cf79f2d90..f5094b03978148ccd64ddb76b6a08a23a5e5b3cd 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc
@@ -12,9 +12,12 @@
#include <utility>
+#include "webrtc/base/logging.h"
+
namespace webrtc {
-AudioNetworkAdaptorImpl::Config::Config() = default;
+AudioNetworkAdaptorImpl::Config::Config()
+ : event_log(nullptr), clock(nullptr){};
AudioNetworkAdaptorImpl::Config::~Config() = default;
@@ -24,7 +27,8 @@ AudioNetworkAdaptorImpl::AudioNetworkAdaptorImpl(
std::unique_ptr<DebugDumpWriter> debug_dump_writer)
: config_(config),
controller_manager_(std::move(controller_manager)),
- debug_dump_writer_(std::move(debug_dump_writer)) {
+ debug_dump_writer_(std::move(debug_dump_writer)),
+ event_log_writer_(config.event_log) {
RTC_DCHECK(controller_manager_);
}
@@ -67,11 +71,12 @@ AudioNetworkAdaptorImpl::GetEncoderRuntimeConfig() {
controller_manager_->GetSortedControllers(last_metrics_))
controller->MakeDecision(last_metrics_, &config);
- // TODO(minyue): Add debug dumping.
if (debug_dump_writer_)
debug_dump_writer_->DumpEncoderRuntimeConfig(
config, config_.clock->TimeInMilliseconds());
+ event_log_writer_.MayLogEncoderRuntimeConfig(config);
+
return config;
}

Powered by Google App Engine
This is Rietveld 408576698