Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2559583002:
Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer (Closed)
|
Created:
4 years ago by Hzj_jie Modified:
4 years ago Reviewers:
Sergey Ulanov CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie, kjellander_webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEnable screen capturer tests for Linux / DirectX capturer / magnifier capturer
GDI capturer may randomly return a blank frame. So this change enables tests for
Linux / DirectX capturer / magnifier capturer.
BUG=webrtc:6666
Committed: https://crrev.com/e83f4b383551b9ac1c1549e48cbd7a1664ce8cde
Cr-Commit-Position: refs/heads/master@{#15489}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #Messages
Total messages: 26 (20 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer GDI capturer may randomly return a blank frame. So this change enables tests for Linux / DirectX capturer / magnifier capturer. BUG=webrtc:6666 ========== to ========== Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer GDI capturer may randomly return a blank frame. So this change enables tests for Linux / DirectX capturer / magnifier capturer. BUG=webrtc:6666 ==========
zijiehe@chromium.org changed reviewers: + sergeyu@chromium.org
lgtm https://codereview.webrtc.org/2559583002/diff/20001/webrtc/modules/desktop_ca... File webrtc/modules/desktop_capture/screen_capturer_integration_test.cc (right): https://codereview.webrtc.org/2559583002/diff/20001/webrtc/modules/desktop_ca... webrtc/modules/desktop_capture/screen_capturer_integration_test.cc:276: if (result == DesktopCapturer::Result::SUCCESS) { Verify that the callback was called, e.g. by calling Mock::VerifyAndClearExpectations(&callback_);
https://codereview.webrtc.org/2559583002/diff/20001/webrtc/modules/desktop_ca... File webrtc/modules/desktop_capture/screen_capturer_integration_test.cc (right): https://codereview.webrtc.org/2559583002/diff/20001/webrtc/modules/desktop_ca... webrtc/modules/desktop_capture/screen_capturer_integration_test.cc:276: if (result == DesktopCapturer::Result::SUCCESS) { On 2016/12/07 19:45:05, Sergey Ulanov wrote: > Verify that the callback was called, e.g. by calling > Mock::VerifyAndClearExpectations(&callback_); Done.
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.webrtc.org/2559583002/#ps80001 (title: "Resolve review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481226096925780,
"parent_rev": "487840e5cf44f6f9675cc849bd1e5fc6023f50a1", "commit_rev":
"ca39e48709f06a814ee6a33da89d339e3b3e683a"}
Message was sent while issue was closed.
Description was changed from ========== Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer GDI capturer may randomly return a blank frame. So this change enables tests for Linux / DirectX capturer / magnifier capturer. BUG=webrtc:6666 ========== to ========== Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer GDI capturer may randomly return a blank frame. So this change enables tests for Linux / DirectX capturer / magnifier capturer. BUG=webrtc:6666 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer GDI capturer may randomly return a blank frame. So this change enables tests for Linux / DirectX capturer / magnifier capturer. BUG=webrtc:6666 ========== to ========== Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer GDI capturer may randomly return a blank frame. So this change enables tests for Linux / DirectX capturer / magnifier capturer. BUG=webrtc:6666 Committed: https://crrev.com/e83f4b383551b9ac1c1549e48cbd7a1664ce8cde Cr-Commit-Position: refs/heads/master@{#15489} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e83f4b383551b9ac1c1549e48cbd7a1664ce8cde Cr-Commit-Position: refs/heads/master@{#15489} |
