Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/android/preferences/pref_service_bridge_unittest.cc

Issue 2559243003: Extend with a language code in http accept languages
Patch Set: Rebased, fixed nits and handed over this CL :( Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/pref_service_bridge.h" 5 #include "chrome/browser/android/preferences/pref_service_bridge.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 11
12 // A test class for PrefServiceBridge class. 12 // A test class for PrefServiceBridge class.
13 class PrefServiceBridgeTest : public testing::Test { 13 class PrefServiceBridgeTest : public testing::Test {
14 public: 14 public:
15 std::string GetAcceptLanguages(std::string locale, 15 std::string GetAcceptLanguages(std::string locale,
16 std::string accept_languages) { 16 std::string accept_languages) {
17 PrefServiceBridge::PrependToAcceptLanguagesIfNecessary(locale, 17 PrefServiceBridge::PrependToAcceptLanguagesIfNecessary(locale,
18 &accept_languages); 18 &accept_languages);
19 return accept_languages; 19 return accept_languages;
20 } 20 }
21 }; 21 };
22 22
23 TEST_F(PrefServiceBridgeTest, PrependToAcceptLanguagesAsNecessary) { 23 TEST_F(PrefServiceBridgeTest, PrependToAcceptLanguagesAsNecessary) {
24 EXPECT_EQ("ms-MY,ms,en-US,en", GetAcceptLanguages("ms-MY", "en-US,en")); 24 EXPECT_EQ("ms-MY,en-US,en", GetAcceptLanguages("ms-MY", "en-US,en"));
25 EXPECT_EQ("de-CH,de,zh-TW,zh,en-US,en", 25 EXPECT_EQ("de-CH,zh-TW,en-US,en",
26 GetAcceptLanguages("de-CH,zh-TW", "en-US,en")); 26 GetAcceptLanguages("de-CH,zh-TW", "en-US,en"));
27 EXPECT_EQ("de-CH,de,zh-TW,zh,fr-FR,fr,en-US,en", 27 EXPECT_EQ("de-CH,zh-TW,fr-FR,en-US,en",
28 GetAcceptLanguages("de-CH,zh-TW,fr-FR", "en-US,en")); 28 GetAcceptLanguages("de-CH,zh-TW,fr-FR", "en-US,en"));
29 29
30 // Make sure a country code in number format is inserted. 30 // Make sure a country code in number format is inserted.
31 EXPECT_EQ("es-419,es-005,es,en-US,en", 31 EXPECT_EQ("es-419,es-005,en-US,en",
32 GetAcceptLanguages("es-419,es-005", "en-US,en")); 32 GetAcceptLanguages("es-419,es-005", "en-US,en"));
33 33
34 // Make sure we do not prepend language code even when a language code already 34 // Make sure we do not prepend language code even when a language code already
35 // exists. 35 // exists.
36 EXPECT_EQ("zh-TW,zh-CN,zh", GetAcceptLanguages("zh-TW", "zh-CN,zh")); 36 EXPECT_EQ("zh-TW,zh-CN,zh", GetAcceptLanguages("zh-TW", "zh-CN,zh"));
37 EXPECT_EQ("de-CH,de-DE,de,en-US,en", 37 EXPECT_EQ("de-CH,de-DE,de,en-US,en",
38 GetAcceptLanguages("de-CH", "de-DE,de,en-US,en")); 38 GetAcceptLanguages("de-CH", "de-DE,de,en-US,en"));
39 EXPECT_EQ("en-GB,de-DE,de,en-US,en", 39 EXPECT_EQ("en-GB,de-DE,en-US,en",
40 GetAcceptLanguages("en-GB,de-DE", "en-US,en")); 40 GetAcceptLanguages("en-GB,de-DE", "en-US,en"));
41 41
42 // Make sure a language code is only inserted after the last languageTag that
43 // contains that language.
44 EXPECT_EQ("fr-CA,fr-FR,fr,en-US,en",
45 GetAcceptLanguages("fr-CA,fr-FR", "en-US,en"));
46
47 // If a country code is missing, then only the language code is inserted. 42 // If a country code is missing, then only the language code is inserted.
48 EXPECT_EQ("ms,en-US,en", GetAcceptLanguages("ms", "en-US,en")); 43 EXPECT_EQ("ms,en-US,en", GetAcceptLanguages("ms", "en-US,en"));
49 EXPECT_EQ("mas,en-US,en", GetAcceptLanguages("mas", "en-US,en")); 44 EXPECT_EQ("mas,en-US,en", GetAcceptLanguages("mas", "en-US,en"));
50 } 45 }
51 46
52 TEST_F(PrefServiceBridgeTest, 47 TEST_F(PrefServiceBridgeTest,
53 ShouldNotPrependToAcceptLanguagesWhenNotNecessary) { 48 ShouldNotPrependToAcceptLanguagesWhenNotNecessary) {
54 // This logic should not affect cases where original accept language already 49 // This logic should not affect cases where original accept language already
55 // reflects the language code in the locale. 50 // reflects the language code in the locale.
56 EXPECT_EQ("mas,en-US,en", GetAcceptLanguages("mas", "en-US,en")); 51 EXPECT_EQ("mas,en-US,en", GetAcceptLanguages("mas", "mas,en-US,en"));
57 EXPECT_EQ("en-US,en", GetAcceptLanguages("en-US", "en-US,en")); 52 EXPECT_EQ("en-US,en", GetAcceptLanguages("en-US", "en-US,en"));
58 EXPECT_EQ("zh-CN,zh", GetAcceptLanguages("zh-CN", "zh-CN,zh")); 53 EXPECT_EQ("zh-CN,zh", GetAcceptLanguages("zh-CN", "zh-CN,zh"));
59 EXPECT_EQ("ms-MY,ms,en-US,en", GetAcceptLanguages("ms-MY,en-US", "en-US,en")); 54 EXPECT_EQ("ms-MY,en-US,en", GetAcceptLanguages("ms-MY,en-US", "en-US,en"));
60 } 55 }
OLDNEW
« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | chrome/browser/net/chrome_http_user_agent_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698