Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: webrtc/test/testsupport/isolated_output_unittest.cc

Issue 2558693002: Add WriteIsolatedOutput() functions (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/test/testsupport/isolated_output_unittest.cc
diff --git a/webrtc/test/testsupport/isolated_output_unittest.cc b/webrtc/test/testsupport/isolated_output_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..28b4bc1315c582246873f75dd99fce56f9eb7aea
--- /dev/null
+++ b/webrtc/test/testsupport/isolated_output_unittest.cc
@@ -0,0 +1,57 @@
+/*
+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/test/testsupport/isolated_output.h"
+
+#include <string.h>
+
+#include <string>
+
+#include "gflags/gflags.h"
+#include "webrtc/base/file.h"
+#include "webrtc/base/pathutils.h"
+#include "webrtc/test/gtest.h"
+
+DECLARE_string(isolated_out_dir);
+
+namespace webrtc {
+namespace test {
+
+TEST(IsolatedOutputTest, ShouldRejectInvalidIsolatedOutDir) {
+ std::string backup = FLAGS_isolated_out_dir;
+ FLAGS_isolated_out_dir = "";
+ ASSERT_FALSE(WriteIsolatedOutput("a-file", "some-contents"));
+ FLAGS_isolated_out_dir = backup;
+}
+
+TEST(IsolatedOutputTest, ShouldRejectInvalidFileName) {
+ ASSERT_FALSE(WriteIsolatedOutput(nullptr, "some-contents"));
+ ASSERT_FALSE(WriteIsolatedOutput("", "some-contents"));
+}
+
+// Sets isolated_out_dir=<a-writable-path> to execute this test.
+TEST(IsolatedOutputTest, ShouldBeAbleToWriteContent) {
+ const char* filename = "a-file";
+ const char* content = "some-contents";
+ if (WriteIsolatedOutput(filename, content)) {
+ rtc::File input =
+ rtc::File::Open(rtc::Pathname(FLAGS_isolated_out_dir, filename));
+ ASSERT_TRUE(input.IsOpen());
+ ASSERT_TRUE(input.Seek(0));
+ uint8_t buffer[32];
+ ASSERT_EQ(input.Read(buffer, strlen(content)), strlen(content));
+ buffer[strlen(content)] = 0;
+ ASSERT_EQ(std::string(content),
+ std::string(reinterpret_cast<char*>(buffer)));
+ }
kjellander_webrtc 2016/12/08 11:51:28 Please add cleaning of the file and ensure it alwa
Hzj_jie 2016/12/08 23:01:09 Done.
+}
+
+} // namespace test
+} // namespace webrtc
« webrtc/test/testsupport/isolated_output.cc ('K') | « webrtc/test/testsupport/isolated_output.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698