Add WriteIsolatedOutput() functions

webrtc/test/testsupport/isolated_output.cc

+/*
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/test/testsupport/isolated_output.h"
+
+#include <string.h>
+
+#include "gflags/gflags.h"
+#include "webrtc/base/file.h"
+#include "webrtc/base/logging.h"
+#include "webrtc/base/pathutils.h"
+
+DEFINE_string(isolated_out_dir, "",
+    "The isolated output folder provided by swarming test framework.");

[kjellander_webrtc, 2016/12/08 11:51:28]

Please make webrtc::test::OutputPath() the default for this flag unless it's
provided.

[Hzj_jie, 2016/12/08 23:01:09]

Done.

+
+namespace webrtc {
+namespace test {
+
+bool WriteIsolatedOutput(const char* filename,
+                         const uint8_t* buffer,
+                         size_t length) {
+  if (FLAGS_isolated_out_dir.empty()) {
+    LOG(LS_WARNING) << "No isolated_out_dir defined.";
+    return false;
+  }
+
+  if (filename == nullptr || strlen(filename) == 0) {
+    LOG(LS_WARNING) << "filename should not be an empty string.";

[kjellander_webrtc, 2016/12/08 11:51:28]

Change to "filename must be provided." since it might be nullptr as well

[Hzj_jie, 2016/12/08 23:01:09]

Done.

+    return false;
+  }
+
+  rtc::File output =
+      rtc::File::Create(rtc::Pathname(FLAGS_isolated_out_dir, filename));
+
+  return output.IsOpen() && output.Write(buffer, length) == length;
+}
+
+bool WriteIsolatedOutput(const char* filename, const std::string& content) {
+  return WriteIsolatedOutput(filename,
+                             reinterpret_cast<const uint8_t*>(content.c_str()),
+                             content.length());
+}
+
+}  // namespace test
+}  // namespace webrtc