Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558303002:
Try to deflake VideoSendStream tests with ULPFEC. (Closed)
DescriptionTry to deflake VideoSendStream tests with ULPFEC.
The changes here are the same as in https://codereview.webrtc.org/2523993002/:
- reduce packet loss from 50% to 5%, to allow the BWE to ramp up better.
- Do not wait for 100 packets to be sent before letting the test pass.
BUG=webrtc:6851
Committed: https://crrev.com/65a1e77202ce4c03a8416965a5d8446949f12544
Cr-Commit-Position: refs/heads/master@{#15542}
Patch Set 1 : Try to deflake VideoSendStream tests with ULPFEC. #Patch Set 2 : Rebase. #
Messages
Total messages: 20 (12 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
brandtr@webrtc.org changed reviewers: + asapersson@webrtc.org, mflodman@webrtc.org
I have not been able to reproduce the time-out flakiness locally using gtest-parallel, neither with nor without this change. This change seems to have worked for the FlexFEC time-out issues, so hopefully it will work on the bots here too.
lgtm
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping mflodman. This flake is apparently becoming more common on the buildbots, so would be good to see if this fix helps or not.
Rebase.
lgtm
The CQ bit was checked by brandtr@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from asapersson@webrtc.org Link to the patchset: https://codereview.webrtc.org/2558303002/#ps60001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481535184208130,
"parent_rev": "711d4ca1f0057451a7ea1577e0656efb227735d0", "commit_rev":
"157fe0031d43bbbccdf410369b73436bd539575b"}
Message was sent while issue was closed.
Description was changed from ========== Try to deflake VideoSendStream tests with ULPFEC. The changes here are the same as in https://codereview.webrtc.org/2523993002/: - reduce packet loss from 50% to 5%, to allow the BWE to ramp up better. - Do not wait for 100 packets to be sent before letting the test pass. BUG=webrtc:6851 ========== to ========== Try to deflake VideoSendStream tests with ULPFEC. The changes here are the same as in https://codereview.webrtc.org/2523993002/: - reduce packet loss from 50% to 5%, to allow the BWE to ramp up better. - Do not wait for 100 packets to be sent before letting the test pass. BUG=webrtc:6851 Review-Url: https://codereview.webrtc.org/2558303002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Try to deflake VideoSendStream tests with ULPFEC. The changes here are the same as in https://codereview.webrtc.org/2523993002/: - reduce packet loss from 50% to 5%, to allow the BWE to ramp up better. - Do not wait for 100 packets to be sent before letting the test pass. BUG=webrtc:6851 Review-Url: https://codereview.webrtc.org/2558303002 ========== to ========== Try to deflake VideoSendStream tests with ULPFEC. The changes here are the same as in https://codereview.webrtc.org/2523993002/: - reduce packet loss from 50% to 5%, to allow the BWE to ramp up better. - Do not wait for 100 packets to be sent before letting the test pass. BUG=webrtc:6851 Committed: https://crrev.com/65a1e77202ce4c03a8416965a5d8446949f12544 Cr-Commit-Position: refs/heads/master@{#15542} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/65a1e77202ce4c03a8416965a5d8446949f12544 Cr-Commit-Position: refs/heads/master@{#15542} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
