RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector.

webrtc/api/rtcstatscollector.cc

Index: webrtc/api/rtcstatscollector.cc
diff --git a/webrtc/api/rtcstatscollector.cc b/webrtc/api/rtcstatscollector.cc
index ec7cbe0bb3ecd646de5f69e7ab2ff8aa608dd7a6..03d056099603aee5a79dbe47e3e0b4d40379cb5b 100644
--- a/webrtc/api/rtcstatscollector.cc
+++ b/webrtc/api/rtcstatscollector.cc
@@ -640,6 +640,8 @@ void RTCStatsCollector::ProduceIceCandidateAndPairStats_s(
             static_cast<uint64_t>(info.recv_ping_responses);
         candidate_pair_stats->responses_sent =
             static_cast<uint64_t>(info.sent_ping_responses);
+        candidate_pair_stats->consent_requests_sent = static_cast<uint64_t>(
+            info.sent_ping_requests_before_first_response);

[hbos, 2016/12/08 15:05:05]

This is the same value that is used by the old getStats for
googCandidatePair.consentRequestsSent.

[Taylor Brandstetter, 2016/12/08 22:01:30]

I think the old implementation is incorrect. If anything, consent requests are
sent after connectivity checks. So "requests_sent" should equal
"sent_ping_requests_before_first_response", and "consent_requests_sent" should
equal "sent_ping_requests_total - sent_ping_requests_before_first_response"...
If my assumptions are correct.

Harald?

[hta-webrtc, 2016/12/09 09:58:25]

Agreed. The defs in
http://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html#dom-rtcicecandida...
aren't very verbose (I'll get on Bernard's case about that), but they indicate
that requests are partitioned into connectivity requests (before first response)
and consent requests (after first response). Seems worthwhile to expand this CL
to generate both of those based on sent_ping_requests_before_first_response and
sent_ping_requests_total - the code is easier to read if both are present.

 
         report->AddStats(std::move(candidate_pair_stats));
       }