RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector.

webrtc/api/rtcstatscollector.cc

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 622 matching lines @@
         // smoothed according to the spec. crbug.com/633550. See
         // https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentrtt
         candidate_pair_stats->current_rtt =
             static_cast<double>(info.rtt) / rtc::kNumMillisecsPerSec;
         candidate_pair_stats->requests_sent =
             static_cast<uint64_t>(info.sent_ping_requests_total);
         candidate_pair_stats->responses_received =
             static_cast<uint64_t>(info.recv_ping_responses);
         candidate_pair_stats->responses_sent =
             static_cast<uint64_t>(info.sent_ping_responses);
+        candidate_pair_stats->consent_requests_sent = static_cast<uint64_t>(
+            info.sent_ping_requests_before_first_response);

[hbos, 2016/12/08 15:05:05]

This is the same value that is used by the old getStats for
googCandidatePair.consentRequestsSent.

[Taylor Brandstetter, 2016/12/08 22:01:30]

I think the old implementation is incorrect. If anything, consent requests are
sent after connectivity checks. So "requests_sent" should equal
"sent_ping_requests_before_first_response", and "consent_requests_sent" should
equal "sent_ping_requests_total - sent_ping_requests_before_first_response"...
If my assumptions are correct.

Harald?

[hta-webrtc, 2016/12/09 09:58:25]

Agreed. The defs in
http://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html#dom-rtcicecandida...
aren't very verbose (I'll get on Bernard's case about that), but they indicate
that requests are partitioned into connectivity requests (before first response)
and consent requests (after first response). Seems worthwhile to expand this CL
to generate both of those based on sent_ping_requests_before_first_response and
sent_ping_requests_total - the code is easier to read if both are present.

 
         report->AddStats(std::move(candidate_pair_stats));
       }
     }
   }
 }
 
 void RTCStatsCollector::ProduceMediaStreamAndTrackStats_s(
     int64_t timestamp_us, RTCStatsReport* report) const {
   RTC_DCHECK(signaling_thread_->IsCurrent());
@@ skipping 260 matching lines @@
     const std::string& type) {
   return CandidateTypeToRTCIceCandidateType(type);
 }
 
 const char* DataStateToRTCDataChannelStateForTesting(
     DataChannelInterface::DataState state) {
   return DataStateToRTCDataChannelState(state);
 }
 
 }  // namespace webrtc