Reland of Add ability to scale to arbitrary factors

Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of https://codereview.webrtc.org/2555483005/ )
>
> Reason for revert:
> Issue discovered with scaling back up.
>
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces a low enough resolution for what was requested. It also ensures that all resolutions provided by the video adapter are divisible by four. This is required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
>
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
>
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

R=magjed@webrtc.org
BUG=webrtc:6837, webrtc:6848
Committed: https://crrev.com/c8474178d66fa774474bae7dc4581dfb3f5b86ac
Cr-Commit-Position: refs/heads/master@{#15485}

[kthelgason, 2016-12-08 13:15:52]

Created Reland of Add ability to scale to arbitrary factors

[kthelgason, 2016-12-08 13:26:30]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:26:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 13:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 13:26:38]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2016-12-08 13:27:30]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 13:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 13:27:38]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2016-12-08 13:28:24]

Description was changed from

==========
Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of
https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at
really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of
https://codereview.webrtc.org/2555483005/ )
> 
> Reason for revert:
> Issue discovered with scaling back up.
> 
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces
a low enough resolution for what was requested. It also ensures that all
resolutions provided by the video adapter are divisible by four. This is
required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
> 
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
> 
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

TBR=magjed@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6837
==========

to

==========
Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of
https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at
really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of
https://codereview.webrtc.org/2555483005/ )
> 
> Reason for revert:
> Issue discovered with scaling back up.
> 
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces
a low enough resolution for what was requested. It also ensures that all
resolutions provided by the video adapter are divisible by four. This is
required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
> 
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
> 
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

R=magjed@webrtc.org
BUG=webrtc:6837,webrtc:6848
==========

[kthelgason, 2016-12-08 13:28:30]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 13:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 13:33:32]

Dry run: Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/16835)

[magjed_webrtc, 2016-12-08 13:45:33]

https://codereview.webrtc.org/2558243003/diff/150001/webrtc/media/base/videoa...
File webrtc/media/base/videoadapter.cc (right):

https://codereview.webrtc.org/2558243003/diff/150001/webrtc/media/base/videoa...
webrtc/media/base/videoadapter.cc:126: // TODO(kthelgason): remove the -
|step_up| hack when we change how
Explain also how this logic works, i.e. we are not allowed to scale up above
requested_format_->width * requested_format_->height.

https://codereview.webrtc.org/2558243003/diff/150001/webrtc/media/base/videoa...
webrtc/media/base/videoadapter.cc:227:
resolution_request_max_pixel_count_step_up_ =
Store |scale_up| instead of |resolution_request_max_pixel_count_step_up_|.

[kthelgason, 2016-12-08 13:53:28]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:53:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 14:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 14:03:25]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/20896)

[kthelgason, 2016-12-08 14:21:20]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 14:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2016-12-08 14:34:57]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 14:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-12-08 14:38:11]

lgtm

[commit-bot: I haz the power, 2016-12-08 15:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:14:36]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2016-12-08 15:14:55]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2016-12-08 15:15:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2016-12-08 15:19:15]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2016-12-08 15:19:16]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2558243003/#ps230001 (title:
"revert changes to vie_encoder")

[commit-bot: I haz the power, 2016-12-08 15:19:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 16:04:51]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1481210355704230,
"parent_rev": "e035882b9a86b95cdd175f1b324b48b1ae31b73f", "commit_rev":
"69d9adb4aeab410bb082f0689e29f234aceb7583"}

[commit-bot: I haz the power, 2016-12-08 16:04:54]

Description was changed from

==========
Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of
https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at
really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of
https://codereview.webrtc.org/2555483005/ )
> 
> Reason for revert:
> Issue discovered with scaling back up.
> 
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces
a low enough resolution for what was requested. It also ensures that all
resolutions provided by the video adapter are divisible by four. This is
required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
> 
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
> 
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

R=magjed@webrtc.org
BUG=webrtc:6837,webrtc:6848
==========

to

==========
Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of
https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at
really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of
https://codereview.webrtc.org/2555483005/ )
> 
> Reason for revert:
> Issue discovered with scaling back up.
> 
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces
a low enough resolution for what was requested. It also ensures that all
resolutions provided by the video adapter are divisible by four. This is
required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
> 
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
> 
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

R=magjed@webrtc.org
BUG=webrtc:6837,webrtc:6848
==========

[commit-bot: I haz the power, 2016-12-08 16:04:55]

Committed patchset #6 (id:230001)

[commit-bot: I haz the power, 2016-12-08 16:05:05]

Description was changed from

==========
Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of
https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at
really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of
https://codereview.webrtc.org/2555483005/ )
> 
> Reason for revert:
> Issue discovered with scaling back up.
> 
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces
a low enough resolution for what was requested. It also ensures that all
resolutions provided by the video adapter are divisible by four. This is
required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
> 
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
> 
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

R=magjed@webrtc.org
BUG=webrtc:6837,webrtc:6848
==========

to

==========
Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of
https://codereview.webrtc.org/2557323002/ )

Reason for revert:
There was a bug in the implementation where the adapter could get stuck at
really low resolutions. That has now been fixed.

Original issue's description:
> Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of
https://codereview.webrtc.org/2555483005/ )
>
> Reason for revert:
> Issue discovered with scaling back up.
>
> Original issue's description:
> > Add ability to scale to arbitrary factors
> >
> > This CL adds a fallback for the case when no optimized scale factor produces
a low enough resolution for what was requested. It also ensures that all
resolutions provided by the video adapter are divisible by four. This is
required by some hardware implementations.
> >
> > BUG=webrtc:6837
> >
> > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f
> > Cr-Commit-Position: refs/heads/master@{#15469}
>
> TBR=magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6837
>
> Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d
> Cr-Commit-Position: refs/heads/master@{#15470}

R=magjed@webrtc.org
BUG=webrtc:6837,webrtc:6848

Committed: https://crrev.com/c8474178d66fa774474bae7dc4581dfb3f5b86ac
Cr-Commit-Position: refs/heads/master@{#15485}
==========

[commit-bot: I haz the power, 2016-12-08 16:05:06]

Patchset 6 (id:??) landed as
https://crrev.com/c8474178d66fa774474bae7dc4581dfb3f5b86ac
Cr-Commit-Position: refs/heads/master@{#15485}