Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webrtc/api/webrtcsdp.cc

Issue 2557803002: Add disabled certificate check support to IceServer PeerConnection API. (Closed)
Patch Set: Add disabled certificate check support to IceServer PeerConnection API. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/webrtcsdp.cc
diff --git a/webrtc/api/webrtcsdp.cc b/webrtc/api/webrtcsdp.cc
index d78112c1680e86ed1b6b20d9105ca6a48a3dd74e..a12272e29993b2cca9488962da3ae962107e3857 100644
--- a/webrtc/api/webrtcsdp.cc
+++ b/webrtc/api/webrtcsdp.cc
@@ -1032,7 +1032,8 @@ bool ParseCandidate(const std::string& message, Candidate* candidate,
SocketAddress address(connection_address, port);
cricket::ProtocolType protocol;
- if (!StringToProto(transport.c_str(), &protocol)) {
+ if (!StringToProto(transport.c_str(), &protocol) ||
+ protocol == cricket::PROTO_TLS) {
pthatcher1 2016/12/07 21:29:35 It seems like we should have StringToProtocol and
Taylor Brandstetter 2016/12/08 01:36:40 I don't follow this comment. What does different t
pthatcher1 2016/12/08 02:36:13 Nevermind. I misunderstood this code.
hnsl1 2016/12/12 16:08:13 Acknowledged.
return ParseFailed(first_line, "Unsupported transport type.", error);
}

Powered by Google App Engine
This is Rietveld 408576698