Add disabled certificate check support to IceServer PeerConnection API.

webrtc/p2p/base/packetsocketfactory.h

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_P2P_BASE_PACKETSOCKETFACTORY_H_
 #define WEBRTC_P2P_BASE_PACKETSOCKETFACTORY_H_
 
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/proxyinfo.h"
 
 namespace rtc {
 
 class AsyncPacketSocket;
 class AsyncResolverInterface;
 
 class PacketSocketFactory {
  public:
   enum Options {
     OPT_SSLTCP = 0x01,  // Pseudo-TLS.
     OPT_TLS = 0x02,
     OPT_STUN = 0x04,
+    OPT_INSECURE_CERT_CHECK = 0x08,  // Disable certificate validation.

[pthatcher1, 2016/12/07 21:29:35]

I think this would be cleaner as:

OPT_FAKE_SSL = 0x01,  // Fake SSL
OPT_TLS = 0x02,
...
OPT_INSECURE_TLS = 0x04


And OPT_INSECURE_TLS is OPT_TLS with insecure CERT check.  Instead of an option
on TLS, it's just a different mode of TLS (like FAKE_SSL) is.  

[hnsl1, 2016/12/12 16:08:13]

If you want to rename OPT_SSLTCP to OPT_FAKE_SSL, I think that could be done in
a separate CL.

I disagree that OPT_SSLTCP/OPT_FAKE_SSL is a different mode of TLS. OPT_FAKE_SSL
is a different mode of TCP, it's not TLS at all. Although you could obviously
also argue that TLS is a different mode of TCP as well, but SSLTCP is closer to
a TCP mode than a TLS mode.

I agree OPT_INSECURE_TLS is a better name, changing.

[pthatcher1, 2016/12/12 23:12:29]

The point I was trying to make is that flattening the modes (Real TLS, Fake SSL,
Unverified TLS) into one dimension would be cleaner than having multiple
dimensions (Real TLS, Fake SSL) + (Unverified TLS).  The names were secondary.  

   };
 
   PacketSocketFactory() { }
   virtual ~PacketSocketFactory() { }
 
   virtual AsyncPacketSocket* CreateUdpSocket(const SocketAddress& address,
                                              uint16_t min_port,
                                              uint16_t max_port) = 0;
   virtual AsyncPacketSocket* CreateServerTcpSocket(
       const SocketAddress& local_address,
@@ skipping 12 matching lines @@
 
   virtual AsyncResolverInterface* CreateAsyncResolver() = 0;
 
  private:
   RTC_DISALLOW_COPY_AND_ASSIGN(PacketSocketFactory);
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_P2P_BASE_PACKETSOCKETFACTORY_H_