Add disabled certificate check support to IceServer PeerConnection API.

webrtc/sdk/android/src/jni/classreferenceholder.cc

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include "webrtc/sdk/android/src/jni/classreferenceholder.h"
@@ skipping 64 matching lines @@
   LoadClass(jni, "org/webrtc/NetworkMonitorAutoDetect$IPAddress");
   LoadClass(jni, "org/webrtc/NetworkMonitorAutoDetect$NetworkInformation");
   LoadClass(jni, "org/webrtc/PeerConnectionFactory");
   LoadClass(jni, "org/webrtc/PeerConnection$BundlePolicy");
   LoadClass(jni, "org/webrtc/PeerConnection$ContinualGatheringPolicy");
   LoadClass(jni, "org/webrtc/PeerConnection$RtcpMuxPolicy");
   LoadClass(jni, "org/webrtc/PeerConnection$IceConnectionState");
   LoadClass(jni, "org/webrtc/PeerConnection$IceGatheringState");
   LoadClass(jni, "org/webrtc/PeerConnection$IceTransportsType");
   LoadClass(jni, "org/webrtc/PeerConnection$TcpCandidatePolicy");
+  LoadClass(jni, "org/webrtc/PeerConnection$TlsCertificatePolicy");

[magjed_webrtc, 2016/12/16 11:57:54]

There is no need to add this unless you want to hold global class references to
TlsCertificatePolicy.

[hnsl1, 2016/12/16 14:18:39]

Without this line I get this runtime JNI crash:

# Fatal error in ***/webrtc/sdk/android/src/jni/classreferenceholder.cc, line
115
# last system error: 11
# Check failed: it != classes_.end()
# Unexpected GetClass() call for: org/webrtc/PeerConnection$TlsCertPolicy
#
A/libc: Fatal signal 6 (SIGABRT), code -6 in tid 23781 (Thread-16)
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
Revision: '0'
ABI: 'arm'
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
backtrace:
...
#04 pc 00017014  /system/lib/libc.so (abort+4)
#05 pc 00ebbd97  (_ZN3rtc12FatalMessageD2Ev+226)
#06 pc 00243519 
(_ZN10webrtc_jni20ClassReferenceHolder8GetClassERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE+280)
#07 pc 00243b31  (_ZN10webrtc_jni9FindClassEP7_JNIEnvPKc+80)
#08 pc 00247c13 
(_ZN10webrtc_jni15GetJavaEnumNameEP7_JNIEnvRKNSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEP8_jobject+130)
#09 pc 00254d85 
(_ZN10webrtc_jniL33JavaTlsCertPolicyTypeToNativeTypeEP7_JNIEnvP8_jobject+76)
#10 pc 0025513b 
(_ZN10webrtc_jniL30JavaIceServersToJsepIceServersEP7_JNIEnvP8_jobjectPNSt3__16vectorIN6webrtc23PeerConnectionInterface9IceServerENS4_9allocatorIS8_EEEE+330)
#11 pc 00255a71 
(_ZN10webrtc_jniL42JavaRTCConfigurationToJsepRTCConfigurationEP7_JNIEnvP8_jobjectPN6webrtc23PeerConnectionInterface16RTCConfigurationE+464)
#12 pc 002568d9  (Java_org_webrtc_PeerConnection_setConfiguration+28)

[magjed_webrtc, 2016/12/19 08:54:05]

You are still using the globally cached FindClass function in
classreferenceholder.h from the GetJavaEnumName function. Can you try changing:
jclass enumClass = FindClass(jni, className.c_str());
to:
jclass enumClass = jni->FindClass(className.c_str());
in GetJavaEnumName in webrtc/sdk/android/src/jni/jni_helpers.cc?

If that doesn't work, then it's ok to do it like this, and we can clean it up
some other day. It's not a big deal, but I don't like the current design where
we load almost every class at start time and store them globally here.

   LoadClass(jni, "org/webrtc/PeerConnection$CandidateNetworkPolicy");
   LoadClass(jni, "org/webrtc/PeerConnection$KeyType");
   LoadClass(jni, "org/webrtc/PeerConnection$SignalingState");
   LoadClass(jni, "org/webrtc/RtpReceiver");
   LoadClass(jni, "org/webrtc/RtpSender");
   LoadClass(jni, "org/webrtc/SessionDescription");
   LoadClass(jni, "org/webrtc/SessionDescription$Type");
   LoadClass(jni, "org/webrtc/StatsReport");
   LoadClass(jni, "org/webrtc/StatsReport$Value");
   LoadClass(jni, "org/webrtc/SurfaceTextureHelper");
@@ skipping 31 matching lines @@
   RTC_CHECK(inserted) << "Duplicate class name: " << name;
 }
 
 // Returns a global reference guaranteed to be valid for the lifetime of the
 // process.
 jclass FindClass(JNIEnv* jni, const char* name) {
   return g_class_reference_holder->GetClass(name);
 }
 
 }  // namespace webrtc_jni