Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 2557793003: Android classreferenceholder.h: Reorder function declaration keywords (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android classreferenceholder.h: Reorder function declaration keywords It should be 'JNIEXPORT rettype JNICALL' not 'rettype JNIEXPORT JNICALL'. BUG=webrtc:6660 Committed: https://crrev.com/06a69849350c11c810a57d4468683032ecc08df8 Cr-Commit-Position: refs/heads/master@{#15467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/sdk/android/src/jni/classreferenceholder.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
magjed_webrtc
Sami - please take a look.
4 years ago (2016-12-07 16:39:31 UTC) #7
sakal
lgtm
4 years ago (2016-12-08 09:06:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2557793003/1
4 years ago (2016-12-08 09:10:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 09:21:45 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 09:21:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06a69849350c11c810a57d4468683032ecc08df8
Cr-Commit-Position: refs/heads/master@{#15467}

Powered by Google App Engine
This is Rietveld 408576698