Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: webrtc/system_wrappers/include/metrics.h

Issue 2557693002: Add comment to metrics.h (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // 1 //
2 // Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 // Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 // 3 //
4 // Use of this source code is governed by a BSD-style license 4 // Use of this source code is governed by a BSD-style license
5 // that can be found in the LICENSE file in the root of the source 5 // that can be found in the LICENSE file in the root of the source
6 // tree. An additional intellectual property rights grant can be found 6 // tree. An additional intellectual property rights grant can be found
7 // in the file PATENTS. All contributing project authors may 7 // in the file PATENTS. All contributing project authors may
8 // be found in the AUTHORS file in the root of the source tree. 8 // be found in the AUTHORS file in the root of the source tree.
9 // 9 //
10 10
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // 51 //
52 // RTC_HISTOGRAM_COUNTS("WebRTC.Video.NacksSent", nacks_sent, 1, 100000, 100); 52 // RTC_HISTOGRAM_COUNTS("WebRTC.Video.NacksSent", nacks_sent, 1, 100000, 100);
53 // 53 //
54 // enum Types { 54 // enum Types {
55 // kTypeX, 55 // kTypeX,
56 // kTypeY, 56 // kTypeY,
57 // kBoundary, 57 // kBoundary,
58 // }; 58 // };
59 // 59 //
60 // RTC_HISTOGRAM_ENUMERATION("WebRTC.Types", kTypeX, kBoundary); 60 // RTC_HISTOGRAM_ENUMERATION("WebRTC.Types", kTypeX, kBoundary);
61 //
62 // NOTE: It is recommended to do the Chromium review for modifications to
63 // histograms.xml before new metrics are committed to WebRTC.
61 64
62 65
63 // Macros for adding samples to a named histogram. 66 // Macros for adding samples to a named histogram.
64 67
65 // Histogram for counters (exponentially spaced buckets). 68 // Histogram for counters (exponentially spaced buckets).
66 #define RTC_HISTOGRAM_COUNTS_100(name, sample) \ 69 #define RTC_HISTOGRAM_COUNTS_100(name, sample) \
67 RTC_HISTOGRAM_COUNTS(name, sample, 1, 100, 50) 70 RTC_HISTOGRAM_COUNTS(name, sample, 1, 100, 50)
68 71
69 #define RTC_HISTOGRAM_COUNTS_200(name, sample) \ 72 #define RTC_HISTOGRAM_COUNTS_200(name, sample) \
70 RTC_HISTOGRAM_COUNTS(name, sample, 1, 200, 50) 73 RTC_HISTOGRAM_COUNTS(name, sample, 1, 200, 50)
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 const std::string& GetHistogramName(Histogram* histogram_pointer); 236 const std::string& GetHistogramName(Histogram* histogram_pointer);
234 237
235 // Function for adding a |sample| to a histogram. 238 // Function for adding a |sample| to a histogram.
236 void HistogramAdd(Histogram* histogram_pointer, int sample); 239 void HistogramAdd(Histogram* histogram_pointer, int sample);
237 240
238 } // namespace metrics 241 } // namespace metrics
239 } // namespace webrtc 242 } // namespace webrtc
240 243
241 #endif // WEBRTC_SYSTEM_WRAPPERS_INCLUDE_METRICS_H_ 244 #endif // WEBRTC_SYSTEM_WRAPPERS_INCLUDE_METRICS_H_
242 245
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698