Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2557323002: Revert of Add ability to scale to arbitrary factors (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of https://codereview.webrtc.org/2555483005/ ) Reason for revert: Issue discovered with scaling back up. Original issue's description: > Add ability to scale to arbitrary factors > > This CL adds a fallback for the case when no optimized scale factor produces a low enough resolution for what was requested. It also ensures that all resolutions provided by the video adapter are divisible by four. This is required by some hardware implementations. > > BUG=webrtc:6837 > > Committed: https://crrev.com/710c335d785b104bda4a912bd7909e4d27f9b04f > Cr-Commit-Position: refs/heads/master@{#15469} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6837 Committed: https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d Cr-Commit-Position: refs/heads/master@{#15470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -88 lines) Patch
M webrtc/media/base/adaptedvideotracksource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/media/base/adaptedvideotracksource.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/base/videoadapter.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/base/videoadapter.cc View 6 chunks +27 lines, -70 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kthelgason
Created Revert of Add ability to scale to arbitrary factors
4 years ago (2016-12-08 10:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2557323002/1
4 years ago (2016-12-08 10:18:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 10:18:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7722a4cc8d31e5e924e9e6c5c97412ce8bbbe59d Cr-Commit-Position: refs/heads/master@{#15470}
4 years ago (2016-12-08 10:18:33 UTC) #7
kthelgason
4 years ago (2016-12-08 13:15:52 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2558243003/ by kthelgason@webrtc.org.

The reason for reverting is: There was a bug in the implementation where the
adapter could get stuck at really low resolutions. That has now been fixed..

Powered by Google App Engine
This is Rietveld 408576698