Refactor webrtc/{api,audio} and modules/audio_coding for GN check

Refactor webrtc/{api,audio} and modules/audio_coding for GN check

This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True

Committed: https://crrev.com/676e08f3b68abb7cafa46c1e46d88dd459cb5231
Cr-Commit-Position: refs/heads/master@{#15461}

[kjellander_webrtc, 2016-12-06 23:01:53]

Description was changed from

==========
Move GN check configurations out of .gn to individual targets.

This changes the check_includes list to be:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

BUG=webrtc:6828
==========

to

==========
Move GN check configurations out of .gn to individual targets.

This changes the check_includes list to be:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
==========

[kjellander_webrtc, 2016-12-06 23:01:53]

kjellander@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2016-12-06 23:44:33]

lgtm

https://codereview.webrtc.org/2556943003/diff/1/.gn
File .gn (right):

https://codereview.webrtc.org/2556943003/diff/1/.gn#newcode33
.gn:33: ]
Ah, the plan is to step by step expand this list until it's equivalent to "*",
at which it'll be a no-op to remove it? Sounds good.

[kjellander_webrtc, 2016-12-07 06:46:12]

Description was changed from

==========
Move GN check configurations out of .gn to individual targets.

This changes the check_includes list to be:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
==========

to

==========
Move GN check configurations out of .gn to individual targets.

This changes the check_includes list to be:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True
==========

[kjellander_webrtc, 2016-12-07 06:48:08]

Description was changed from

==========
Move GN check configurations out of .gn to individual targets.

This changes the check_includes list to be:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor webrtc/{api,audio} and modules/audio_coding for GN check

This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True
==========

[kjellander_webrtc, 2016-12-07 15:15:47]

Patchset #4 (id:60001) has been deleted

[kjellander_webrtc, 2016-12-07 16:21:36]

https://codereview.webrtc.org/2556943003/diff/1/.gn
File .gn (right):

https://codereview.webrtc.org/2556943003/diff/1/.gn#newcode33
.gn:33: ]
On 2016/12/06 23:44:33, kwiberg-webrtc wrote:
> Ah, the plan is to step by step expand this list until it's equivalent to "*",
> at which it'll be a no-op to remove it? Sounds good.

Yes, this CL would get too big if I would do it all in one step. I also wanted
to keep the review sane.

[kjellander_webrtc, 2016-12-07 16:21:45]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-12-07 16:21:46]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2556943003/#ps100001 (title:
"More Android fixes")

[commit-bot: I haz the power, 2016-12-07 16:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-07 16:23:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481127705527530,
"parent_rev": "94ed522a26bd85cb627719b254b11d77ce8545aa", "commit_rev":
"d96d785fbdf5850880ec2354db8eebc5eb6c31c6"}

[commit-bot: I haz the power, 2016-12-07 16:23:29]

Description was changed from

==========
Refactor webrtc/{api,audio} and modules/audio_coding for GN check

This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor webrtc/{api,audio} and modules/audio_coding for GN check

This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True
==========

[commit-bot: I haz the power, 2016-12-07 16:23:30]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-07 16:23:38]

Description was changed from

==========
Refactor webrtc/{api,audio} and modules/audio_coding for GN check

This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor webrtc/{api,audio} and modules/audio_coding for GN check

This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",

Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.

Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.

BUG=webrtc:6828
NOTRY=True

Committed: https://crrev.com/676e08f3b68abb7cafa46c1e46d88dd459cb5231
Cr-Commit-Position: refs/heads/master@{#15461}
==========

[commit-bot: I haz the power, 2016-12-07 16:23:42]

Patchset 5 (id:??) landed as
https://crrev.com/676e08f3b68abb7cafa46c1e46d88dd459cb5231
Cr-Commit-Position: refs/heads/master@{#15461}