webrtc/api/peerconnection_unittest.cc - Issue 2556783002: Fix out of bound reads in ParseIceServerUrl() for various input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnection_unittest.cc

Issue 2556783002: Fix out of bound reads in ParseIceServerUrl() for various input. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnection_unittest.cc

diff --git a/webrtc/api/peerconnection_unittest.cc b/webrtc/api/peerconnection_unittest.cc

index 301fed55dbce0659d4fcd45eae8c5ad48d2308ff..48accb5bd922904c7eac5e6a4cf4947bf31f12e7 100644

--- a/webrtc/api/peerconnection_unittest.cc

+++ b/webrtc/api/peerconnection_unittest.cc

@@ -2749,6 +2749,9 @@ TEST_F(IceServerParsingTest, ParseTransport) {

turn_servers_.clear();

EXPECT_FALSE(ParseUrl("turn:hostname?transport=invalid"));

+ EXPECT_FALSE(ParseUrl("turn:hostname?transport="));

+ EXPECT_FALSE(ParseUrl("turn:hostname?="));

+ EXPECT_FALSE(ParseUrl("?"));

}

// Test parsing ICE username contained in URL.

« webrtc/api/peerconnection.cc ('K') | « webrtc/api/peerconnection.cc ('k') | no next file » | no next file with comments »