Chromium Code Reviews

Issue 2555813003: Add a tool to fix (some) errors reported by gn gen --check. (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a tool to fix (some) errors reported by gn gen --check. BUG=webrtc:6828 R=kjellander@webrtc.org NOTRY=True Committed: https://crrev.com/01653b1130934b809816f7a5ad3c4b8c73d8d411 Cr-Commit-Position: refs/heads/master@{#15483}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Some improvements. #

Patch Set 3 : More improvements! #

Total comments: 2

Patch Set 4 : Use a temporary dir. Style changes. #

Patch Set 5 : Revert .gn #

Unified diffs Side-by-side diffs Stats (+142 lines, -0 lines)
A tools/gn_check_autofix.py View 1 chunk +142 lines, -0 lines 0 comments

Messages

Total messages: 17 (6 generated)
ehmaldonado_webrtc
Just FYI :) There are some lint errors that I need to fix, and small ...
4 years ago (2016-12-07 12:20:25 UTC) #1
kjellander_webrtc
This is very nice! It would probably have saved me an hour of work yesterday. ...
4 years ago (2016-12-07 12:31:38 UTC) #2
kjellander_webrtc
On 2016/12/07 12:31:38, kjellander_webrtc wrote: > This is very nice! It would probably have saved ...
4 years ago (2016-12-07 12:32:08 UTC) #4
ehmaldonado_webrtc
Made some improvements. Now it puts the deps inside the deps ;) Don't review it ...
4 years ago (2016-12-07 12:58:21 UTC) #5
ehmaldonado_webrtc
On 2016/12/07 12:58:21, ehmaldonado_webrtc wrote: > Made some improvements. Now it puts the deps inside ...
4 years ago (2016-12-07 16:58:00 UTC) #6
kjellander_webrtc
Very nice! I'm missing my previous comments being addressed still. https://codereview.webrtc.org/2555813003/diff/40001/.gn File .gn (right): https://codereview.webrtc.org/2555813003/diff/40001/.gn#newcode33 ...
4 years ago (2016-12-08 11:57:23 UTC) #7
ehmaldonado_webrtc
I've clean it up a bit now. I should probably add some documentation. Now you ...
4 years ago (2016-12-08 14:19:48 UTC) #8
kjellander_webrtc
Using MB is a good idea! My only concern is that for some platforms it'll ...
4 years ago (2016-12-08 15:00:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2555813003/80001
4 years ago (2016-12-08 15:24:06 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-08 15:27:40 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-08 15:27:50 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/01653b1130934b809816f7a5ad3c4b8c73d8d411
Cr-Commit-Position: refs/heads/master@{#15483}

Powered by Google App Engine