Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2555333004: Refactor webrtc/modules/video_{capture,coding} for GN check (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor webrtc/modules/video_{capture,coding} for GN check This moves some GN check configurations out of .gn to individual targets. The now checked target is: "//webrtc/modules/video_capture/*", "//webrtc/modules/video_coding/*", BUG=webrtc:6828 NOTRY=True R=kjellander@webrtc.org Committed: https://crrev.com/36df2d76c5dd65cf300f9c833311af2ca3694f3f Cr-Commit-Position: refs/heads/master@{#15488}

Patch Set 1 #

Patch Set 2 : Added webrtc/modules/video_coding/* #

Patch Set 3 : Fixed android. #

Total comments: 2

Patch Set 4 : Fixed error in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M .gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 4 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 3 7 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ehmaldonado_webrtc
4 years ago (2016-12-08 16:24:51 UTC) #2
kjellander_webrtc
Just one fix needed https://codereview.webrtc.org/2555333004/diff/40001/webrtc/modules/video_coding/BUILD.gn File webrtc/modules/video_coding/BUILD.gn (right): https://codereview.webrtc.org/2555333004/diff/40001/webrtc/modules/video_coding/BUILD.gn#newcode109 webrtc/modules/video_coding/BUILD.gn:109: # Errors on cyclic dependency ...
4 years ago (2016-12-08 17:02:44 UTC) #3
ehmaldonado_webrtc
PTAL https://codereview.webrtc.org/2555333004/diff/40001/webrtc/modules/video_coding/BUILD.gn File webrtc/modules/video_coding/BUILD.gn (right): https://codereview.webrtc.org/2555333004/diff/40001/webrtc/modules/video_coding/BUILD.gn#newcode109 webrtc/modules/video_coding/BUILD.gn:109: # Errors on cyclic dependency with :audio_processing if ...
4 years ago (2016-12-08 17:13:45 UTC) #5
kjellander_webrtc
lgtm
4 years ago (2016-12-08 17:34:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2555333004/80001
4 years ago (2016-12-08 17:54:41 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years ago (2016-12-08 17:56:20 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 17:56:26 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/36df2d76c5dd65cf300f9c833311af2ca3694f3f
Cr-Commit-Position: refs/heads/master@{#15488}

Powered by Google App Engine
This is Rietveld 408576698