Make ostream<< for enum class H264PacketizationMode

webrtc/modules/include/module_common_types.h

Index: webrtc/modules/include/module_common_types.h
diff --git a/webrtc/modules/include/module_common_types.h b/webrtc/modules/include/module_common_types.h
index 3df93b6c89a050fb05603a0d5987a2a7c982a2d8..b79401a7bebb2499812f5782c584bcb2f1486dad 100644
--- a/webrtc/modules/include/module_common_types.h
+++ b/webrtc/modules/include/module_common_types.h
@@ -271,6 +271,21 @@ enum class H264PacketizationMode {
   SingleNalUnit        // Mode 0 - only single NALU allowed
 };
 
+// This function is declared inline because it is not clear which
+// .cc file it should belong to.

[sprang_webrtc, 2016/12/06 11:32:55]

Could you add a file-level TODO instead (and maybe even file a tracking bug), to
add a source file for module_common_types? Looking around, there's an awful lot
of inline code in this file, feels like it deserves a home of its own...

[kwiberg-webrtc, 2016/12/06 11:40:19]

I'd really prefer to have this in a .cc file instead. This function has no
business being inline.

Now, webrtc/modules/include/module_common_types.h is #included by a large number
of files, but it's not part of any GN build target. That's wrong, and it makes
it impossible to move definitions such as this one out of the header. (And it
looks like there are several other functions in this file that also should not
be inline.)

Ideally, I'd like you to put this function in a new .cc file,
module_common_types.cc, and set up a build target for the new .h+.cc pair. I
realize this is a bunch of cleanup work you may not have time for, though, so
alternatively you could just post a bug saying that this should be done, and
point to it from a comment in this file.

+inline std::ostream& operator<<(std::ostream& stream,
+                                H264PacketizationMode mode) {
+  switch (mode) {
+    case H264PacketizationMode::NonInterleaved:
+      stream << "NonInterleaved";
+      break;
+    case H264PacketizationMode::SingleNalUnit:
+      stream << "SingleNalUnit";
+      break;
+  }
+  return stream;
+}
+
 struct NaluInfo {
   uint8_t type;
   int sps_id;