Parse FlexFEC RTP headers in Call and add integration with BWE.

webrtc/call/flexfec_receive_stream.cc

Index: webrtc/call/flexfec_receive_stream.cc
diff --git a/webrtc/call/flexfec_receive_stream.cc b/webrtc/call/flexfec_receive_stream.cc
index 61a31418ccda31af061dbb8e50a2dd4b030bf649..56b41b04cd4348ade3035f6b9dfc5ea5a0a3baf3 100644
--- a/webrtc/call/flexfec_receive_stream.cc
+++ b/webrtc/call/flexfec_receive_stream.cc
@@ -34,12 +34,12 @@ std::string FlexfecReceiveStream::Config::ToString() const {
   if (!protected_media_ssrcs.empty())
     ss << protected_media_ssrcs[i];
   ss << "], transport_cc: " << (transport_cc ? "on" : "off");
-  ss << ", extensions: [";
+  ss << ", rtp_header_extensions: [";
   i = 0;
-  for (; i + 1 < extensions.size(); ++i)
-    ss << extensions[i].ToString() << ", ";
-  if (!extensions.empty())
-    ss << extensions[i].ToString();
+  for (; i + 1 < rtp_header_extensions.size(); ++i)
+    ss << rtp_header_extensions[i].ToString() << ", ";
+  if (!rtp_header_extensions.empty())
+    ss << rtp_header_extensions[i].ToString();
   ss << "]}";
   return ss.str();
 }
@@ -49,7 +49,7 @@ namespace {
 // TODO(brandtr): Update this function when we support multistream protection.
 std::unique_ptr<FlexfecReceiver> MaybeCreateFlexfecReceiver(
     const FlexfecReceiveStream::Config& config,
-    RecoveredPacketReceiver* recovered_packet_callback) {
+    RecoveredPacketReceiver* recovered_packet_receiver) {
   if (config.payload_type < 0) {
     LOG(LS_WARNING) << "Invalid FlexFEC payload type given. "
                     << "This FlexfecReceiveStream will therefore be useless.";
@@ -79,7 +79,7 @@ std::unique_ptr<FlexfecReceiver> MaybeCreateFlexfecReceiver(
   RTC_DCHECK_EQ(1U, config.protected_media_ssrcs.size());
   return std::unique_ptr<FlexfecReceiver>(
       new FlexfecReceiver(config.remote_ssrc, config.protected_media_ssrcs[0],
-                          recovered_packet_callback));
+                          recovered_packet_receiver));
 }
 
 }  // namespace
@@ -88,11 +88,11 @@ namespace internal {
 
 FlexfecReceiveStream::FlexfecReceiveStream(
     const Config& config,
-    RecoveredPacketReceiver* recovered_packet_callback)
+    RecoveredPacketReceiver* recovered_packet_receiver)
     : started_(false),
       config_(config),
       receiver_(
-          MaybeCreateFlexfecReceiver(config_, recovered_packet_callback)) {
+          MaybeCreateFlexfecReceiver(config_, recovered_packet_receiver)) {
   LOG(LS_INFO) << "FlexfecReceiveStream: " << config_.ToString();
 }
 
@@ -101,8 +101,8 @@ FlexfecReceiveStream::~FlexfecReceiveStream() {
   Stop();
 }
 
-bool FlexfecReceiveStream::AddAndProcessReceivedPacket(const uint8_t* packet,
-                                                       size_t packet_length) {
+bool FlexfecReceiveStream::AddAndProcessReceivedPacket(
+    RtpPacketReceived packet) {
   {
     rtc::CritScope cs(&crit_);
     if (!started_)
@@ -110,7 +110,7 @@ bool FlexfecReceiveStream::AddAndProcessReceivedPacket(const uint8_t* packet,
   }
   if (!receiver_)
     return false;
-  return receiver_->AddAndProcessReceivedPacket(packet, packet_length);
+  return receiver_->AddAndProcessReceivedPacket(packet);

[danilchap, 2016/12/14 13:39:02]

either move or pass by const&

[brandtr, 2016/12/14 14:08:31]

I was going to ask you about that in the email, but forgot. After studying
rtp_packet.h, I got the feeling that rtp::Packet should be treated as a value
type, since there are no explicitly defined constructors and since the main data
is carried by the COW buffer. Anyway, I've added back the std::move's!

I like std::move better than const& here, since when the packet has been passed
down to FlexfecReceiver, a copy is made of it, and the original packet is thrown
away. With the move's, it's clear where the packet is thrown away.

 }
 
 void FlexfecReceiveStream::Start() {