Parse FlexFEC RTP headers in Call and add integration with BWE.

webrtc/modules/congestion_controller/congestion_controller.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/congestion_controller/include/congestion_controller.h"
 
 #include <algorithm>
 #include <memory>
 #include <vector>
 
 #include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/rate_limiter.h"
 #include "webrtc/base/socket.h"
 #include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
 #include "webrtc/modules/congestion_controller/probe_controller.h"
 #include "webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h"
 #include "webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h"
 #include "webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h"
+#include "webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h"
+#include "webrtc/modules/rtp_rtcp/source/rtp_packet_received.h"
 #include "webrtc/system_wrappers/include/critical_section_wrapper.h"
 
 namespace webrtc {
 namespace {
 
 static const uint32_t kTimeOffsetSwitchThreshold = 30;
 static const int64_t kRetransmitWindowSizeMs = 500;
 
 // Makes sure that the bitrate and the min, max values are in valid range.
 static void ClampBitrates(int* bitrate_bps,
@@ skipping 154 matching lines @@
       last_reported_bitrate_bps_(0),
       last_reported_fraction_loss_(0),
       last_reported_rtt_(0),
       network_state_(kNetworkUp) {
   transport_feedback_adapter_.InitBwe();
   transport_feedback_adapter_.SetMinBitrate(min_bitrate_bps_);
 }
 
 CongestionController::~CongestionController() {}
 
+void CongestionController::NotifyBweOfReceivedPacket(

[stefan-webrtc, 2016/12/19 14:03:31]

Call this method "OnReceivedPacket"

[brandtr, 2016/12/19 14:26:53]

Done. Alternatively, it could also be called "IncomingPacket", and would then
have the same signature as RemoteBitrateEstimator::IncomingPacket.

[stefan-webrtc, 2016/12/19 15:50:30]

Agree, but now it resembles OnSentPacket below, which I also find nice. :)

+    const RtpPacketReceived& packet) {
+  const bool transport_wide = packet.HasExtension<TransportSequenceNumber>();
+  const bool abs_send_time = packet.HasExtension<AbsoluteSendTime>();
+  const bool t_offset = packet.HasExtension<TransmissionOffset>();

[stefan-webrtc, 2016/12/19 14:03:31]

One more tiny request...

Could we move out the rtp specific stuff here and only pass in arrival time,
payload size and, for now, the header?

[brandtr, 2016/12/19 14:26:53]

Done.

+
+  // At least one of the header extensions is needed for the BWE.
+  if (!transport_wide && !abs_send_time && !t_offset)
+    return;
+
+  RTPHeader header;
+  packet.GetHeader(&header);
+
+  // Send-side BWE.
+  if (transport_wide) {
+    remote_estimator_proxy_.IncomingPacket(packet.arrival_time_ms(),
+                                           packet.payload_size(), header);
+    return;
+  }
+
+  // Receive-side BWE.
+  if (remote_bitrate_estimator_) {
+    remote_bitrate_estimator_->IncomingPacket(packet.arrival_time_ms(),
+                                              packet.payload_size(), header);
+  }
+}
+
 void CongestionController::SetBweBitrates(int min_bitrate_bps,
                                           int start_bitrate_bps,
                                           int max_bitrate_bps) {
   ClampBitrates(&start_bitrate_bps, &min_bitrate_bps, &max_bitrate_bps);
   bitrate_controller_->SetBitrates(start_bitrate_bps,
                                    min_bitrate_bps,
                                    max_bitrate_bps);
 
   probe_controller_->SetBitrates(min_bitrate_bps, start_bitrate_bps,
                                  max_bitrate_bps);
@@ skipping 154 matching lines @@
 bool CongestionController::IsSendQueueFull() const {
   return pacer_->ExpectedQueueTimeMs() > PacedSender::kMaxQueueLengthMs;
 }
 
 bool CongestionController::IsNetworkDown() const {
   rtc::CritScope cs(&critsect_);
   return network_state_ == kNetworkDown;
 }
 
 }  // namespace webrtc