Parse FlexFEC RTP headers in Call and add integration with BWE.

webrtc/modules/rtp_rtcp/include/flexfec_receiver.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_FLEXFEC_RECEIVER_H_
 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_FLEXFEC_RECEIVER_H_
 
 #include <memory>
 
 #include "webrtc/base/basictypes.h"
 #include "webrtc/base/sequenced_task_checker.h"
 #include "webrtc/call.h"
 #include "webrtc/modules/rtp_rtcp/include/flexfec_receiver.h"

[danilchap, 2016/12/06 15:04:30]

unrelated question: is it a self-include?

[brandtr, 2016/12/12 13:51:07]

Yes! This was removed in another CL, that this CL replaces. So I missed to
remove it here. Thanks for finding!

(This is from the days when there was both an interface and an implementation.
That is no longer the case.)

 #include "webrtc/modules/rtp_rtcp/include/ulpfec_receiver.h"
 #include "webrtc/modules/rtp_rtcp/source/forward_error_correction.h"
 #include "webrtc/system_wrappers/include/clock.h"
 
 namespace webrtc {
 
+class RemoteBitrateEstimator;
+class RtpPacketReceived;
+
 // Callback interface for packets recovered by FlexFEC. The implementation
 // should be able to demultiplex the recovered RTP packets based on SSRC.
 class RecoveredPacketReceiver {
  public:
   virtual bool OnRecoveredPacket(const uint8_t* packet, size_t length) = 0;
 
  protected:
   virtual ~RecoveredPacketReceiver() = default;
 };
 
 class FlexfecReceiver {
  public:
   FlexfecReceiver(uint32_t ssrc,
                   uint32_t protected_media_ssrc,
-                  RecoveredPacketReceiver* callback);
+                  RecoveredPacketReceiver* recovered_packet_receiver,
+                  RemoteBitrateEstimator* remote_bitrate_estimator);
   ~FlexfecReceiver();
 
   // Inserts a received packet (can be either media or FlexFEC) into the
   // internal buffer, and sends the received packets to the erasure code.
   // All newly recovered packets are sent back through the callback.
-  bool AddAndProcessReceivedPacket(const uint8_t* packet, size_t packet_length);
+  bool AddAndProcessReceivedPacket(RtpPacketReceived packet);

[danilchap, 2016/12/06 15:04:30]

to pass by value forward declaration is not enough.
include header with the definition or pass by const&.

[brandtr, 2016/12/12 13:51:07]

Done.

 
   // Returns a counter describing the added and recovered packets.
   FecPacketCounter GetPacketCounter() const;
 
  private:
-  bool AddReceivedPacket(const uint8_t* packet, size_t packet_length);
+  bool AddReceivedPacket(RtpPacketReceived packet);
   bool ProcessReceivedPackets();
 
   // Config.
   const uint32_t ssrc_;
   const uint32_t protected_media_ssrc_;
 
   // Erasure code interfacing and callback.
   std::unique_ptr<ForwardErrorCorrection> erasure_code_;
   ForwardErrorCorrection::ReceivedPacketList received_packets_;
   ForwardErrorCorrection::RecoveredPacketList recovered_packets_;
-  RecoveredPacketReceiver* const callback_;
+  RecoveredPacketReceiver* const recovered_packet_receiver_;
+
+  // BWE.
+  RemoteBitrateEstimator* remote_bitrate_estimator_;
 
   // Logging and stats.
   Clock* const clock_;
   int64_t last_recovered_packet_ms_;
   FecPacketCounter packet_counter_;
 
   rtc::SequencedTaskChecker sequence_checker_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_RTP_RTCP_INCLUDE_FLEXFEC_RECEIVER_H_