Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: webrtc/tools/frame_analyzer/frame_analyzer.cc

Issue 2553693002: Comparison of videos with reference frame not starting from zero (Closed)
Patch Set: Updated based on review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/tools/frame_analyzer/frame_analyzer.cc
diff --git a/webrtc/tools/frame_analyzer/frame_analyzer.cc b/webrtc/tools/frame_analyzer/frame_analyzer.cc
index 80201093272112d48398610342bdd64fbb363b64..0bd1fadf46be36065d671db211f81ce3e0affea1 100644
--- a/webrtc/tools/frame_analyzer/frame_analyzer.cc
+++ b/webrtc/tools/frame_analyzer/frame_analyzer.cc
@@ -41,8 +41,12 @@
*/
int main(int argc, char** argv) {
std::string program_name = argv[0];
- std::string usage = "Compares the output video with the initially sent video."
- "\nExample usage:\n" + program_name + " --stats_file=stats.txt "
+ // TODO(mandermo) fix comment
+ std::string usage =
+ "Compares the output video with the initially sent video."
+ "\nExample usage:\n" +
+ program_name +
+ " --stats_file=stats.txt "
"--reference_file=ref.yuv --test_file=test.yuv --width=320 --height=240\n"
"Command line flags:\n"
" - width(int): The width of the reference and test files. Default: -1\n"
@@ -50,8 +54,12 @@ int main(int argc, char** argv) {
" Default: -1\n"
" - label(string): The label to use for the perf output."
" Default: MY_TEST\n"
- " - stats_file(string): The full name of the file containing the stats"
- " after decoding of the received YUV video. Default: stats.txt\n"
+ " - stats_file_ref(string): The full name of the file containing the"
phoglund 2016/12/12 12:46:20 That's a mouthful. What about "The stats file, as
mandermo 2016/12/21 16:42:06 Improved text. Is new text better?
+ " stats file for the reference video file after decoding of the received"
+ " YUV reference video. Default: stats_ref.txt\n"
+ " - stats_file_test(string): The full name of the file containing the"
+ " stats for the test video file after decoding of the received YUV test"
+ " video. Default: stats_test.txt\n"
" - reference_file(string): The reference YUV file to compare against."
" Default: ref.yuv\n"
" - test_file(string): The test YUV file to run the analysis for."
@@ -66,7 +74,8 @@ int main(int argc, char** argv) {
parser.SetFlag("width", "-1");
parser.SetFlag("height", "-1");
parser.SetFlag("label", "MY_TEST");
- parser.SetFlag("stats_file", "stats.txt");
+ parser.SetFlag("stats_file_ref", "stats_ref.txt");
+ parser.SetFlag("stats_file_test", "stats_test.txt");
parser.SetFlag("reference_file", "ref.yuv");
parser.SetFlag("test_file", "test.yuv");
parser.SetFlag("help", "false");
@@ -90,11 +99,13 @@ int main(int argc, char** argv) {
webrtc::test::RunAnalysis(parser.GetFlag("reference_file").c_str(),
parser.GetFlag("test_file").c_str(),
- parser.GetFlag("stats_file").c_str(), width, height,
- &results);
+ parser.GetFlag("stats_file_ref").c_str(),
+ parser.GetFlag("stats_file_test").c_str(), width,
+ height, &results);
std::string label = parser.GetFlag("label");
webrtc::test::PrintAnalysisResults(label, &results);
- webrtc::test::PrintMaxRepeatedAndSkippedFrames(label,
- parser.GetFlag("stats_file"));
+ webrtc::test::PrintMaxRepeatedAndSkippedFrames(
+ label, parser.GetFlag("stats_file_ref"),
+ parser.GetFlag("stats_file_test"));
}

Powered by Google App Engine
This is Rietveld 408576698