Clean up redundant include of ../webrtc_overrides

Clean up redundant include of ../webrtc_overrides

BUG=webrtc:6424
R=kjellander@webrtc.org

Committed: https://crrev.com/7495c8c3acbd01b8792ad2d961ff14f221d618d4
Cr-Commit-Position: refs/heads/master@{#15459}

[ehmaldonado_webrtc, 2016-12-05 15:12:04]

I looked into the ninja files and it seems to be redundant.

[kjellander_webrtc, 2016-12-06 08:46:03]

kjellander@webrtc.org changed reviewers:
+ henrikg@webrtc.org, perkj@webrtc.org

[kjellander_webrtc, 2016-12-06 08:46:03]

+perkj and henrikg since they added two of them - maybe there was a reason for
it?

The entry in
https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=0&l=44
seems to be sufficient.

[Henrik Grunell WebRTC, 2016-12-06 09:09:14]

On 2016/12/06 08:46:03, kjellander_webrtc wrote:
> +perkj and henrikg since they added two of them - maybe there was a reason for
> it?
> 
> The entry in
> https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=0&l=44
> seems to be sufficient.

If that config is included in the targets that are changed in the CL, sure, it
should be sufficient. I can't recall why it was added.

I suggest building Chrome before and after the change and confirm the right
headers are still included (maybe add #error at suitable places or so).

/Henrik

[ehmaldonado_webrtc, 2016-12-06 15:58:44]

On 2016/12/06 09:09:14, Henrik Grunell (WebRTC) wrote:
> On 2016/12/06 08:46:03, kjellander_webrtc wrote:
> > +perkj and henrikg since they added two of them - maybe there was a reason
for
> > it?
> > 
> > The entry in
> > https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=0&l=44
> > seems to be sufficient.
> 
> If that config is included in the targets that are changed in the CL, sure, it
> should be sufficient. I can't recall why it was added.
> 
> I suggest building Chrome before and after the change and confirm the right
> headers are still included (maybe add #error at suitable places or so).
> 
> /Henrik

I looked into the generated ninja files inside a Chromium checkout. Without
this, the include paths appear twice, with this, they only appear once.

[Henrik Grunell WebRTC, 2016-12-07 07:43:01]

On 2016/12/06 15:58:44, ehmaldonado_webrtc wrote:
> On 2016/12/06 09:09:14, Henrik Grunell (WebRTC) wrote:
> > On 2016/12/06 08:46:03, kjellander_webrtc wrote:
> > > +perkj and henrikg since they added two of them - maybe there was a reason
> for
> > > it?
> > > 
> > > The entry in
> > >
https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=0&l=44
> > > seems to be sufficient.
> > 
> > If that config is included in the targets that are changed in the CL, sure,
it
> > should be sufficient. I can't recall why it was added.
> > 
> > I suggest building Chrome before and after the change and confirm the right
> > headers are still included (maybe add #error at suitable places or so).
> > 
> > /Henrik
> 
> I looked into the generated ninja files inside a Chromium checkout. Without
> this, the include paths appear twice, with this, they only appear once.

OK, sounds good. I also compared the line count (= number of targets) greping
for "webrtc_overrides" in the generated files without and with the change, it's
equal.

lgtm

[perkj_webrtc, 2016-12-07 09:19:55]

On 2016/12/07 07:43:01, Henrik Grunell (WebRTC) wrote:
> On 2016/12/06 15:58:44, ehmaldonado_webrtc wrote:
> > On 2016/12/06 09:09:14, Henrik Grunell (WebRTC) wrote:
> > > On 2016/12/06 08:46:03, kjellander_webrtc wrote:
> > > > +perkj and henrikg since they added two of them - maybe there was a
reason
> > for
> > > > it?
> > > > 
> > > > The entry in
> > > >
> https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=0&l=44
> > > > seems to be sufficient.
> > > 
> > > If that config is included in the targets that are changed in the CL,
sure,
> it
> > > should be sufficient. I can't recall why it was added.
> > > 
> > > I suggest building Chrome before and after the change and confirm the
right
> > > headers are still included (maybe add #error at suitable places or so).
> > > 
> > > /Henrik
> > 
> > I looked into the generated ninja files inside a Chromium checkout. Without
> > this, the include paths appear twice, with this, they only appear once.
> 
> OK, sounds good. I also compared the line count (= number of targets) greping
> for "webrtc_overrides" in the generated files without and with the change,
it's
> equal.
> 
> lgtm

lgtm

[ehmaldonado_webrtc, 2016-12-07 11:04:40]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-12-07 11:04:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-07 11:30:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481108680209730, "parent_rev":
"bb087ce878b16d785625a57daffb9f3073b15c0e", "commit_rev":
"0588f892f5ed8355e3ecd8a599d2ba3365db41ea"}

[commit-bot: I haz the power, 2016-12-07 11:30:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 11:30:53]

Description was changed from

==========
Clean up redundant include of ../webrtc_overrides

BUG=webrtc:6424
R=kjellander@webrtc.org
==========

to

==========
Clean up redundant include of ../webrtc_overrides

BUG=webrtc:6424
R=kjellander@webrtc.org

Committed: https://crrev.com/7495c8c3acbd01b8792ad2d961ff14f221d618d4
Cr-Commit-Position: refs/heads/master@{#15459}
==========

[commit-bot: I haz the power, 2016-12-07 11:30:54]

Patchset 1 (id:??) landed as
https://crrev.com/7495c8c3acbd01b8792ad2d961ff14f221d618d4
Cr-Commit-Position: refs/heads/master@{#15459}