Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2553613002: Revert "Revert of Use different restrictions of acked bitrate lag depending on operating point. (pa… (Closed)

Created:
4 years ago by stefan-webrtc
Modified:
4 years ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Revert of Use different restrictions of acked bitrate lag depending on operating point. (patchset #3 id:40001 of https://codereview.webrtc.org/2542083003/ )" This reverts commit 2e59a02dd49c122a0e848baaebb7a38faf20dec4. BUG=webrtc:5079 Committed: https://crrev.com/db752f9b373f58f0b03d8c1eea11b60460aaca6d Cr-Commit-Position: refs/heads/master@{#15425}

Patch Set 1 #

Patch Set 2 : Fix flaky tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -11 lines) Patch
M webrtc/call/rampup_tests.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 1 3 chunks +13 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
stefan-webrtc
Fix flaky tests.
4 years ago (2016-12-05 12:53:16 UTC) #1
stefan-webrtc
reland after fixing test.
4 years ago (2016-12-05 12:54:35 UTC) #3
stefan-webrtc
The tests failed because the expected bitrate was too high for audio. They simply succeeded ...
4 years ago (2016-12-05 12:55:26 UTC) #4
terelius
lgtm
4 years ago (2016-12-05 16:07:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553613002/20001
4 years ago (2016-12-05 16:07:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 16:23:44 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-05 16:24:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db752f9b373f58f0b03d8c1eea11b60460aaca6d
Cr-Commit-Position: refs/heads/master@{#15425}

Powered by Google App Engine
This is Rietveld 408576698