Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2553043004: Revert of Refactoring that removes P2PTransport and DtlsTransport classes. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactoring that removes P2PTransport and DtlsTransport classes. (patchset #9 id:150001 of https://codereview.webrtc.org/2517883002/ ) Reason for revert: Deletion of transport.h broke downstream builds. Going to reland with transport.h containing enums/etc. Original issue's description: > Refactoring that removes P2PTransport and DtlsTransport classes. > > Their base class, Transport, still exists, but it now has a more specific > role: a helper class that applies TransportDescriptions. And is renamed > to JsepTransport as a result. > > TransportController is now the entity primarily responsible for managing > TransportChannels. It also starts storing pointers to the DTLS and ICE > chanels separately, which will make it easier to remove > TransportChannel/TransportChannelImpl in a subsequent CL. > > BUG=None > > Committed: https://crrev.com/bd28681d02dee8c185aeb39207e8154f0ad14a37 > Cr-Commit-Position: refs/heads/master@{#15450} TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/57fd7263d1d5bfe27e7c540b5251485da6a7c30e Cr-Commit-Position: refs/heads/master@{#15452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2163 lines, -1674 lines) Patch
M webrtc/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/api/statscollector_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download
A webrtc/p2p/base/dtlstransport.h View 1 chunk +163 lines, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 14 chunks +47 lines, -59 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 5 chunks +208 lines, -64 lines 0 comments Download
D webrtc/p2p/base/jseptransport.h View 1 chunk +0 lines, -377 lines 0 comments Download
D webrtc/p2p/base/jseptransport.cc View 1 chunk +0 lines, -439 lines 0 comments Download
D webrtc/p2p/base/jseptransport_unittest.cc View 1 chunk +0 lines, -272 lines 0 comments Download
A webrtc/p2p/base/p2ptransport.h View 1 chunk +39 lines, -0 lines 0 comments Download
A webrtc/p2p/base/p2ptransport.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/p2p/base/transport.h View 1 chunk +423 lines, -0 lines 0 comments Download
A webrtc/p2p/base/transport.cc View 1 chunk +472 lines, -0 lines 0 comments Download
A webrtc/p2p/base/transport_unittest.cc View 1 chunk +423 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 9 chunks +43 lines, -79 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 18 chunks +158 lines, -260 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M webrtc/p2p/client/socketmonitor.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/quic/quictransport.h View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 26 chunks +92 lines, -64 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M webrtc/pc/mediasession.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
Created Revert of Refactoring that removes P2PTransport and DtlsTransport classes.
4 years ago (2016-12-06 23:28:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553043004/1
4 years ago (2016-12-06 23:28:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 23:29:03 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-06 23:29:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57fd7263d1d5bfe27e7c540b5251485da6a7c30e
Cr-Commit-Position: refs/heads/master@{#15452}

Powered by Google App Engine
This is Rietveld 408576698