Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 2552883010: Do not update OnReceivedRtcpReceiverReport if report block list is empty (and rtt zero). (Closed)

Created:
4 years ago by åsapersson
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not update OnReceivedRtcpReceiverReport if report block list is empty (and rtt zero). For example, zero rtt may be reported to: BitrateControllerImpl::OnReceivedRtcpReceiverReport: - SendSideBandwidthEstimation::UpdateReceiverBlock - SendSideBandwidthEstimation::UpdateUmaStats BitrateAllocator::OnNetworkChanged: - ProtectionBitrateCalculator::SetTargetRates Re-add check that was removed in https://codereview.webrtc.org/2422063002. BUG=webrtc:6692 Committed: https://crrev.com/8d193a72bc9e97b6fb6d59c813b0eb7cc0eeb03f Cr-Commit-Position: refs/heads/master@{#15486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
åsapersson
4 years ago (2016-12-08 15:05:20 UTC) #5
stefan-webrtc
lgtm, thanks!
4 years ago (2016-12-08 15:45:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2552883010/1
4 years ago (2016-12-08 16:11:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 16:13:05 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 16:13:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d193a72bc9e97b6fb6d59c813b0eb7cc0eeb03f
Cr-Commit-Position: refs/heads/master@{#15486}

Powered by Google App Engine
This is Rietveld 408576698