Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2551813002: Use RTC_DISALLOW_COPY_AND_ASSIGN in webrtc/base/sigslottester.h (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RTC_DISALLOW_COPY_AND_ASSIGN in webrtc/base/sigslottester.h It was incorrectly using a older version of the macro, which wasn't discovered since the code wasn't built in WebRTC until now. I moved webrtc/base/sigslottester.h from rtc_unittests into rtc_base_test_utils instead to make it more usable. BUG=webrtc:6821 Committed: https://crrev.com/1d08100b9e1db449c943ce64663c10a019834a09 Cr-Commit-Position: refs/heads/master@{#15422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/sigslottester.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/sigslottester.h.pump View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kjellander_webrtc
4 years ago (2016-12-05 09:19:40 UTC) #6
perkj_webrtc
lgtm
4 years ago (2016-12-05 14:03:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2551813002/1
4 years ago (2016-12-05 14:12:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 14:14:32 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 14:14:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d08100b9e1db449c943ce64663c10a019834a09
Cr-Commit-Position: refs/heads/master@{#15422}

Powered by Google App Engine
This is Rietveld 408576698