Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2550453003: Revert of Disabled flaky P2PTestConductor tests on ASAN and MSAN. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Disabled flaky P2PTestConductor tests on ASAN and MSAN. (patchset #1 id:1 of https://codereview.webrtc.org/2539103002/ ) Reason for revert: The flaky tests should now be fixed. Original issue's description: > Disabled flaky P2PTestConductor tests on ASAN and MSAN. > > TBR=deadbeef@webrtc.org > BUG=webrtc:6776 > > Committed: https://crrev.com/8d66a5a3b18eef73b238f4220477da265bf4494b > Cr-Commit-Position: refs/heads/master@{#15324} TBR=ossu@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6776 Committed: https://crrev.com/8f89bff9a61acdd34bf71efea6ef4e7a7b93db12 Cr-Commit-Position: refs/heads/master@{#15371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 3 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
Created Revert of Disabled flaky P2PTestConductor tests on ASAN and MSAN.
4 years ago (2016-12-01 20:37:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2550453003/1
4 years ago (2016-12-01 20:37:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:54:23 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-01 20:54:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f89bff9a61acdd34bf71efea6ef4e7a7b93db12
Cr-Commit-Position: refs/heads/master@{#15371}

Powered by Google App Engine
This is Rietveld 408576698