Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2550423004: Use SSL_CTX_set_max_proto_version instead of SSL_CTX_set_max_version. (Closed)

Created:
4 years ago by davidben_webrtc
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use SSL_CTX_set_max_proto_version instead of SSL_CTX_set_max_version. These functions are identical. BoringSSL added these APIs, then OpenSSL 1.1.0 added similar ones but with slightly longer names. We're standardizing on the OpenSSL names to avoid API skew. BUG=none Committed: https://crrev.com/e36c46ede34a845f1304a8c750367ef7fde0a29c Cr-Commit-Position: refs/heads/master@{#15455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/base/opensslstreamadapter.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
davidben_webrtc
4 years ago (2016-12-06 22:57:45 UTC) #5
pthatcher1
lgtm
4 years ago (2016-12-07 01:04:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2550423004/1
4 years ago (2016-12-07 01:05:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 01:12:06 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-07 01:12:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e36c46ede34a845f1304a8c750367ef7fde0a29c
Cr-Commit-Position: refs/heads/master@{#15455}

Powered by Google App Engine
This is Rietveld 408576698