Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2550393002: Add FlexFEC settings toggle in Android AppRTCMobile. (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add FlexFEC settings toggle in Android AppRTCMobile. BUG=webrtc:5654 Committed: https://crrev.com/0582e6ca36134b8e9b2dcd000762d67c1782bc1e Cr-Commit-Position: refs/heads/master@{#15481}

Patch Set 1 #

Messages

Total messages: 17 (8 generated)
brandtr
Please take a look :) sakal: androidapp/ magjed: androidtests/
4 years ago (2016-12-06 08:39:41 UTC) #2
magjed_webrtc
lgtm
4 years ago (2016-12-06 16:55:46 UTC) #3
sakal
This change lgtm. Enabling FlexFEC causes a crash for me though.
4 years ago (2016-12-08 09:38:57 UTC) #4
brandtr_google
On 2016/12/08 09:38:57, sakal wrote: > This change lgtm. Enabling FlexFEC causes a crash for ...
4 years ago (2016-12-08 09:44:02 UTC) #5
sakal
I was using a low bitrate in a loopback call. I sent you the stack ...
4 years ago (2016-12-08 10:00:36 UTC) #6
brandtr
On 2016/12/08 10:00:36, sakal wrote: > I was using a low bitrate in a loopback ...
4 years ago (2016-12-08 14:49:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2550393002/1
4 years ago (2016-12-08 14:49:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 14:51:31 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-08 14:51:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0582e6ca36134b8e9b2dcd000762d67c1782bc1e
Cr-Commit-Position: refs/heads/master@{#15481}

Powered by Google App Engine
This is Rietveld 408576698