Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2550273003: Moved call.h and most of api/call/* into call/ (Closed)

Created:
4 years ago by ossu
Modified:
4 years ago
Reviewers:
the sun, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, hlundin-webrtc, yujie_mao (webrtc), kwiberg-webrtc, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, danilchap, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved call.h and most of api/call/* into call/ BUG=webrtc:6716 Committed: https://crrev.com/f515ab8c3f24befe83a548b8056708acb24b6bb7 Cr-Commit-Position: refs/heads/master@{#15460}

Patch Set 1 #

Patch Set 2 : Separated headers into :call_interfaces; update deps #

Total comments: 2

Patch Set 3 : Added <set> include after presubmit complained. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -679 lines) Patch
M webrtc/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/api/DEPS View 1 chunk +12 lines, -0 lines 0 comments Download
D webrtc/api/call/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/api/call/audio_receive_stream.h View 1 chunk +0 lines, -142 lines 0 comments Download
D webrtc/api/call/audio_send_stream.h View 1 chunk +0 lines, -145 lines 0 comments Download
D webrtc/api/call/audio_send_stream.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D webrtc/api/call/audio_state.h View 1 chunk +0 lines, -49 lines 0 comments Download
M webrtc/api/mediacontroller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnection.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/audio_state.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call.h View 1 chunk +3 lines, -155 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 2 chunks +12 lines, -0 lines 0 comments Download
A + webrtc/call/audio_receive_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/call/audio_send_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/call/audio_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/call/audio_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/call/call.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/call/call.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/call/rampup_tests.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log2rtp_dump.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/mediaengine.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcmediaengine.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/call_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/direct_transport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_network_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_network_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/layer_filtering_transport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/replay.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
ossu
I've had to separate call/ into two targets, call and call_interfaces. Some things, like logging, ...
4 years ago (2016-12-06 16:05:02 UTC) #3
the sun
lgtm https://codereview.webrtc.org/2550273003/diff/40001/webrtc/call/BUILD.gn File webrtc/call/BUILD.gn (right): https://codereview.webrtc.org/2550273003/diff/40001/webrtc/call/BUILD.gn#newcode14 webrtc/call/BUILD.gn:14: "audio_send_stream.cc", On 2016/12/06 16:05:02, ossu wrote: > Since ...
4 years ago (2016-12-06 21:43:22 UTC) #5
mflodman
LGTM, thanks Oskar!
4 years ago (2016-12-07 12:02:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2550273003/40001
4 years ago (2016-12-07 12:16:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11147)
4 years ago (2016-12-07 12:19:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2550273003/60001
4 years ago (2016-12-07 12:39:16 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-07 12:53:03 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-07 12:53:12 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f515ab8c3f24befe83a548b8056708acb24b6bb7
Cr-Commit-Position: refs/heads/master@{#15460}

Powered by Google App Engine
This is Rietveld 408576698