fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=webrtc:6812
Committed: https://crrev.com/df28e47a4b817db7cb2b1892ea00f23c74c4706b
Cr-Commit-Position: refs/heads/master@{#15383}

[zhengpeng, 2016-12-01 12:43:06]

howtofly@gmail.com changed reviewers:
+ holmer@chromium.org, terelius@webrtc.org

[zhengpeng, 2016-12-01 12:43:06]

Modify as terelius suggests.
https://codereview.webrtc.org/2537043003/

[zhengpeng, 2016-12-01 12:45:48]

The CQ bit was checked by howtofly@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 12:45:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 12:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 12:45:56]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[terelius, 2016-12-01 12:59:35]

https://codereview.webrtc.org/2549453002/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):

https://codereview.webrtc.org/2549453002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:74: const uint32_t
threshold = static_cast<uint32_t> (0.5 * LatestEstimate());
Please add a line
TODO(terelius/holmer): Investigate consequences of increasing the threshold to
0.95 * LatestEstimate().

[zhengpeng, 2016-12-01 15:56:19]

On 2016/12/01 12:59:35, terelius wrote:
>
https://codereview.webrtc.org/2549453002/diff/1/webrtc/modules/remote_bitrate...
> File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):
> 
>
https://codereview.webrtc.org/2549453002/diff/1/webrtc/modules/remote_bitrate...
> webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:74: const
uint32_t
> threshold = static_cast<uint32_t> (0.5 * LatestEstimate());
> Please add a line
> TODO(terelius/holmer): Investigate consequences of increasing the threshold to
> 0.95 * LatestEstimate().

patch updated.

[terelius, 2016-12-01 16:06:46]

lgtm

[zhengpeng, 2016-12-01 16:14:34]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-01 16:14:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[zhengpeng, 2016-12-01 16:14:42]

The CQ bit was unchecked by howtofly@gmail.com

[zhengpeng, 2016-12-01 16:14:47]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-01 16:14:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 16:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 16:17:29]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10953)

[zhengpeng, 2016-12-01 16:30:20]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-01 16:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 16:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 16:33:34]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10957)

[zhengpeng, 2016-12-01 16:35:45]

The CQ bit was unchecked by howtofly@gmail.com

[zhengpeng, 2016-12-01 16:36:19]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-01 16:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 16:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 16:39:14]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10960)

[terelius, 2016-12-01 16:45:36]

I'm not owner for these files. You still need an lgtm from stefan to be able to
land the CL.

[zhengpeng, 2016-12-01 16:45:53]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-01 16:46:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2016-12-01 16:47:05]

The CQ bit was unchecked by terelius@webrtc.org

[zhengpeng, 2016-12-01 16:52:19]

On 2016/12/01 16:45:36, terelius wrote:
> I'm not owner for these files. You still need an lgtm from stefan to be able
to
> land the CL.

Just curiously playing with the CQ, sorry.

[zhengpeng, 2016-12-01 16:55:38]

Description was changed from

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=
==========

to

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=
==========

[zhengpeng, 2016-12-01 16:55:38]

howtofly@gmail.com changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-12-02 09:15:38]

lgtm

https://codereview.webrtc.org/2549453002/diff/20001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):

https://codereview.webrtc.org/2549453002/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:76: const uint32_t
threshold = static_cast<uint32_t> (0.5 * LatestEstimate());
remove space between > and (

[zhengpeng, 2016-12-02 11:10:04]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-02 11:10:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 11:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 11:13:04]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11001)

[zhengpeng, 2016-12-02 11:15:51]

howtofly@gmail.com changed reviewers:
- holmer@chromium.org

[zhengpeng, 2016-12-02 11:24:40]

Description was changed from

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=
==========

to

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=webrtc:6812
==========

[zhengpeng, 2016-12-02 11:25:48]

The CQ bit was checked by howtofly@gmail.com

[commit-bot: I haz the power, 2016-12-02 11:25:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 11:27:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480677948002100,
"parent_rev": "ffb7a276b956f9d79cf23d4be994d0181b59aa3e", "commit_rev":
"96724eafdaab297daab5a9723e2654e5b0e622f7"}

[commit-bot: I haz the power, 2016-12-02 11:27:11]

Description was changed from

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=webrtc:6812
==========

to

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=webrtc:6812
==========

[commit-bot: I haz the power, 2016-12-02 11:27:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 11:27:25]

Description was changed from

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=webrtc:6812
==========

to

==========
fix coding and documentary ambiguity in AimdRateControl::TimeToReduceFurther.

BUG=webrtc:6812

Committed: https://crrev.com/df28e47a4b817db7cb2b1892ea00f23c74c4706b
Cr-Commit-Position: refs/heads/master@{#15383}
==========

[commit-bot: I haz the power, 2016-12-02 11:27:26]

Patchset 2 (id:??) landed as
https://crrev.com/df28e47a4b817db7cb2b1892ea00f23c74c4706b
Cr-Commit-Position: refs/heads/master@{#15383}

[zhengpeng, 2016-12-02 11:34:29]

On 2016/12/02 09:15:38, stefan-webrtc (holmer) wrote:
> lgtm
> 
>
https://codereview.webrtc.org/2549453002/diff/20001/webrtc/modules/remote_bit...
> File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):
> 
>
https://codereview.webrtc.org/2549453002/diff/20001/webrtc/modules/remote_bit...
> webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:76: const
uint32_t
> threshold = static_cast<uint32_t> (0.5 * LatestEstimate());
> remove space between > and (

sorry for ignoring this. Too excited when playing CQ, which is so cool!