Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2549403002: Robustifying and simplifying the level controller complexity tests (Closed)

Created:
4 years ago by peah-webrtc
Modified:
4 years ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

The level controller complexity tests have lately been flaky, with many false results and with a huge variance. This CL addresses that by changing the way the API call durations are measured, using a warmup period and a longer interval for computing the timing estimates. Furthermore, this CL reduces the number of tests to compensate for the fact that the tests now are more expensive, as well as to reduce the number of regressions further. BUG=webrtc:6614, webrtc:6685, 666725 Committed: https://crrev.com/dbc960c045ddb7f166a3d715614cff4680658572 Cr-Commit-Position: refs/heads/master@{#15440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc View 4 chunks +25 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
peah-webrtc
phoglund@: PTAL Thanks!
4 years ago (2016-12-06 08:06:37 UTC) #3
phoglund
lgtm
4 years ago (2016-12-06 10:34:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2549403002/1
4 years ago (2016-12-06 11:52:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 12:11:29 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 12:11:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbc960c045ddb7f166a3d715614cff4680658572
Cr-Commit-Position: refs/heads/master@{#15440}

Powered by Google App Engine
This is Rietveld 408576698