Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: webrtc/test/BUILD.gn

Issue 2548713003: Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/build/webrtc.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index 1b3c05973ac7c1a17ee9e69c389e4b43893afbcb..1a668439e56a29e32aebc9945aff77a84c79dd77 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -110,8 +110,6 @@ rtc_source_set("test_support") {
sources = [
"gmock.h",
"gtest.h",
- "testsupport/fileutils.cc",
- "testsupport/fileutils.h",
"testsupport/frame_reader.cc",
"testsupport/frame_reader.h",
"testsupport/frame_writer.cc",
@@ -130,6 +128,7 @@ rtc_source_set("test_support") {
]
deps = [
+ ":fileutils",
":video_test_common",
"../base:gtest_prod",
"../base:rtc_base_approved",
@@ -204,7 +203,6 @@ rtc_test("test_support_unittests") {
"rtp_file_reader_unittest.cc",
"rtp_file_writer_unittest.cc",
"testsupport/always_passing_unittest.cc",
- "testsupport/fileutils_unittest.cc",
"testsupport/frame_reader_unittest.cc",
"testsupport/frame_writer_unittest.cc",
"testsupport/metrics/video_metrics_unittest.cc",
@@ -236,6 +234,7 @@ rtc_test("test_support_unittests") {
}
deps += [
+ ":fileutils_unittests",
":test_common",
":test_main",
"../modules/video_capture",
@@ -388,3 +387,26 @@ rtc_source_set("test_renderer") {
"//testing/gtest",
]
}
+
+rtc_source_set("fileutils") {
kjellander_webrtc 2016/12/02 14:31:08 Move these closer to the reference
+ testonly = true
+ sources = [
+ "testsupport/fileutils.cc",
+ "testsupport/fileutils.h",
+ ]
+}
+rtc_source_set("fileutils_unittests") {
+ testonly = true
+ sources = [
+ "testsupport/fileutils_unittest.cc",
+ ]
+ deps = [
+ ":default_fileutils",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+}
« no previous file with comments | « webrtc/build/webrtc.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698