Delete deprecated CongestionController constructor and packet_router method.

Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=webrtc:6847
Committed: https://crrev.com/7dada5e4c09c073f68ec2f7e73622075ebecaf5a
Cr-Commit-Position: refs/heads/master@{#15484}

[nisse-webrtc, 2016-12-02 14:05:23]

nisse@webrtc.org changed reviewers:
+ stefan@webrtc.org

[nisse-webrtc, 2016-12-08 08:27:42]

Description was changed from

==========
Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=None.
==========

to

==========
Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=webrtc:6847
==========

[nisse-webrtc, 2016-12-08 12:16:49]

I think we can now land this, downstream is updated. (And the chromium fyi
failure looks unrelated).

[stefan-webrtc, 2016-12-08 14:36:57]

lgtm

[nisse-webrtc, 2016-12-08 14:45:00]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-12-08 14:45:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 15:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:03:40]

Failed to apply patch for
webrtc/modules/congestion_controller/include/congestion_controller.h:
While running git apply --index -p1;
  error: patch failed:
webrtc/modules/congestion_controller/include/congestion_controller.h:94
  error: webrtc/modules/congestion_controller/include/congestion_controller.h:
patch does not apply

Patch:      
webrtc/modules/congestion_controller/include/congestion_controller.h
Index: webrtc/modules/congestion_controller/include/congestion_controller.h
diff --git
a/webrtc/modules/congestion_controller/include/congestion_controller.h
b/webrtc/modules/congestion_controller/include/congestion_controller.h
index
f2bec76f2523c175b90577f24c72f3a1c56040c2..15e340550247858f09d97bc990d4c1c4358c7d79
100644
--- a/webrtc/modules/congestion_controller/include/congestion_controller.h
+++ b/webrtc/modules/congestion_controller/include/congestion_controller.h
@@ -67,11 +67,6 @@ class CongestionController : public CallStatsObserver, public
Module {
                        RemoteBitrateObserver* remote_bitrate_observer,
                        RtcEventLog* event_log,
                        PacketRouter* packet_router);
-  // TODO(nisse): Deprecated. Will create and own a PacketRouter.
-  CongestionController(Clock* clock,
-                       Observer* observer,
-                       RemoteBitrateObserver* remote_bitrate_observer,
-                       RtcEventLog* event_log);
   CongestionController(Clock* clock,
                        Observer* observer,
                        RemoteBitrateObserver* remote_bitrate_observer,
@@ -94,8 +89,6 @@ class CongestionController : public CallStatsObserver, public
Module {
       bool send_side_bwe);
   virtual int64_t GetPacerQueuingDelayMs() const;
   virtual PacedSender* pacer() { return pacer_.get(); }
-  // TODO(nisse): Deprecated, but still used by downstream projects.
-  virtual PacketRouter* packet_router() { return packet_router_; }
   virtual TransportFeedbackObserver* GetTransportFeedbackObserver();
   RateLimiter* GetRetransmissionRateLimiter();
   void EnablePeriodicAlrProbing(bool enable);
@@ -132,9 +125,6 @@ class CongestionController : public CallStatsObserver,
public Module {
                                            int64_t rtt);
   Clock* const clock_;
   Observer* const observer_;
-  // Used by the deprecated constructor, where caller doesn't provide
-  // the packet_router.
-  std::unique_ptr<PacketRouter> owned_packet_router_;
   PacketRouter* const packet_router_;
   const std::unique_ptr<PacedSender> pacer_;
   const std::unique_ptr<RemoteBitrateEstimator> remote_bitrate_estimator_;

[nisse-webrtc, 2016-12-08 15:13:37]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-12-08 15:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2548633003/#ps20001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-12-08 15:13:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-08 15:49:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481210017302840,
"parent_rev": "8029b2164a5b3e6dc2a7f49d5b0c0fb77a2996e7", "commit_rev":
"e035882b9a86b95cdd175f1b324b48b1ae31b73f"}

[commit-bot: I haz the power, 2016-12-08 15:49:03]

Description was changed from

==========
Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=webrtc:6847
==========

to

==========
Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=webrtc:6847
==========

[commit-bot: I haz the power, 2016-12-08 15:49:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 15:49:10]

Description was changed from

==========
Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=webrtc:6847
==========

to

==========
Delete deprecated CongestionController constructor and packet_router method.

This is a followup to https://codereview.webrtc.org/2516983004/, to be
landed after downstream projects are updated.

BUG=webrtc:6847

Committed: https://crrev.com/7dada5e4c09c073f68ec2f7e73622075ebecaf5a
Cr-Commit-Position: refs/heads/master@{#15484}
==========

[commit-bot: I haz the power, 2016-12-08 15:49:11]

Patchset 2 (id:??) landed as
https://crrev.com/7dada5e4c09c073f68ec2f7e73622075ebecaf5a
Cr-Commit-Position: refs/heads/master@{#15484}