Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2548333002: Revert of APM: Change 3 UMA metrics to fewer but linearly distributed buckets (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
rkaplow, peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of APM: Change 3 UMA metrics to fewer but linearly distributed buckets (patchset #2 id:20001 of https://codereview.webrtc.org/2547593002/ ) Reason for revert: Breaks down-stream dependencies. Original issue's description: > APM: Change 3 UMA metrics to fewer but linearly distributed buckets > > In this change WebRTC.Audio.ApmCaptureInputLevel{Average,Peak} are > changed to 64 buckets, while WebRTC.Audio.AgcLevel is changed to 50 > buckets. All three are changed to have linear spacing between buckets. > > Also, the metrics are renamed to avoid stats conflicts because of different bucket schemes: > - WebRTC.Audio.AgcLevel -> WebRTC.Audio.AgcSetLevel > - WebRTC.Audio.ApmCaptureInputLevelAverage -> WebRTC.Audio.ApmCaptureInputLevelAverageRms > - WebRTC.Audio.ApmCaptureInputLevelPeakRms -> WebRTC.Audio.ApmCaptureInputLevelPeakRms > > BUG=webrtc:6622 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng > > Committed: https://crrev.com/49715fe3be17d8579586d5bc954d626126d53415 > Cr-Commit-Position: refs/heads/master@{#15418} TBR=peah@webrtc.org,rkaplow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6622 Committed: https://crrev.com/63407a9b6ae6f3fc096e01d64e46c6d21d86b517 Cr-Commit-Position: refs/heads/master@{#15420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M webrtc/modules/audio_processing/agc/agc_manager_direct.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
Created Revert of APM: Change 3 UMA metrics to fewer but linearly distributed buckets
4 years ago (2016-12-05 13:11:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2548333002/1
4 years ago (2016-12-05 13:11:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 13:11:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/63407a9b6ae6f3fc096e01d64e46c6d21d86b517 Cr-Commit-Position: refs/heads/master@{#15420}
4 years ago (2016-12-05 13:11:41 UTC) #7
hlundin-webrtc
4 years ago (2016-12-06 07:48:02 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2551863003/ by henrik.lundin@webrtc.org.

The reason for reverting is: The downstream problem is now fixed, and this
should be good to land again..

Powered by Google App Engine
This is Rietveld 408576698