Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2547673002: In end-to-end PeerConnection tests, allow video to be downscaled. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In end-to-end PeerConnection tests, allow video to be downscaled. QualityScaler may scale down the resolution, so our tests shouldn't expect the input resolution to exactly match the resolution received on the other side. Instead, we now just check that the aspect ratio matches. BUG=webrtc:5907 Committed: https://crrev.com/b465980fd7f94769d2bcf0f0ae8b8e05704d136d Cr-Commit-Position: refs/heads/master@{#15373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
PTAL; this has been causing more frequent failures on the Win32 Debug bot lately.
4 years ago (2016-12-01 21:30:14 UTC) #3
pthatcher1
lgtm
4 years ago (2016-12-01 22:50:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2547673002/1
4 years ago (2016-12-02 00:01:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 00:23:33 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-02 00:23:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b465980fd7f94769d2bcf0f0ae8b8e05704d136d
Cr-Commit-Position: refs/heads/master@{#15373}

Powered by Google App Engine
This is Rietveld 408576698