Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2547113002: Revert of Use different restrictions of acked bitrate lag depending on operating point. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use different restrictions of acked bitrate lag depending on operating point. (patchset #3 id:40001 of https://codereview.webrtc.org/2542083003/ ) Reason for revert: Appears to cause a regression to RampUpTest.SendSideAudioOnlyUpDownUpRtx: https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus6%29/builds/626 Original issue's description: > Use different restrictions of acked bitrate lag depending on operating point. > > Before this the BWE was allowed to operate freely up to 100 kbps. This isn't a good idea for audio BWE. > > BUG=webrtc:5079 > > Committed: https://crrev.com/5932149c9aeaa7679ad0bc3183047766832ca907 > Cr-Commit-Position: refs/heads/master@{#15389} TBR=terelius@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5079 Committed: https://crrev.com/2e59a02dd49c122a0e848baaebb7a38faf20dec4 Cr-Commit-Position: refs/heads/master@{#15394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -46 lines) Patch
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
Created Revert of Use different restrictions of acked bitrate lag depending on operating point.
4 years ago (2016-12-02 19:29:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2547113002/1
4 years ago (2016-12-02 19:29:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 19:29:38 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-02 19:29:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e59a02dd49c122a0e848baaebb7a38faf20dec4
Cr-Commit-Position: refs/heads/master@{#15394}

Powered by Google App Engine
This is Rietveld 408576698