Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2546723003: New gn target video_frame_api. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

New gn target video_frame_api. This is in preparation for https://codereview.webrtc.org/2517173004/, which needs some updates of downstream dependencies. This cl adds the target to api/BUILD.gn, creates the directory api/video, and a single harmless include file there. BUG=webrtc:5880 Committed: https://crrev.com/b2250e5dbb8fb5aec5ef3c7962667e031a87b9a0 Cr-Commit-Position: refs/heads/master@{#15385}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +23 lines, -0 lines 1 comment Download
A webrtc/api/video/video_rotation.h View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nisse-webrtc
4 years ago (2016-12-02 08:46:21 UTC) #2
the sun
lgtm
4 years ago (2016-12-02 09:30:53 UTC) #3
kjellander_webrtc
lgtm but run a few trybots + the internal one. https://codereview.webrtc.org/2546723003/diff/1/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/2546723003/diff/1/webrtc/api/BUILD.gn#newcode384 ...
4 years ago (2016-12-02 10:09:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2546723003/1
4 years ago (2016-12-02 11:43:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 12:01:18 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-02 12:01:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2250e5dbb8fb5aec5ef3c7962667e031a87b9a0
Cr-Commit-Position: refs/heads/master@{#15385}

Powered by Google App Engine
This is Rietveld 408576698