Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2546703002: Remove OnLocalSsrcChanged (Closed)

Created:
4 years ago by mflodman
Modified:
4 years ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove OnLocalSsrcChanged Removing the unused interface OnLocalSsrcChanged. BUG=webrtc:6456 Committed: https://crrev.com/e90adcef4283cbf589fb4dda835a3c0fb2febe65 Cr-Commit-Position: refs/heads/master@{#15354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
mflodman
Danil, This just removes an unused interface. Can you take a look?
4 years ago (2016-12-01 10:27:44 UTC) #4
danilchap
lgtm
4 years ago (2016-12-01 10:31:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2546703002/1
4 years ago (2016-12-01 10:38:07 UTC) #10
mflodman
On 2016/12/01 10:31:26, danilchap wrote: > lgtm Thanks Danil!
4 years ago (2016-12-01 10:38:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 10:39:44 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 10:39:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e90adcef4283cbf589fb4dda835a3c0fb2febe65
Cr-Commit-Position: refs/heads/master@{#15354}

Powered by Google App Engine
This is Rietveld 408576698