Fix exponential probing in ProbeController.

Fix exponential probing in ProbeController.

https://codereview.webrtc.org/2504023002 broke exponential probing.
After that change ProbeController stops exponential probes prematurely:
it goes to kProbingComplete state if SetEstimatedBitrate() is called
with bitrate lower than min_bitrate_to_probe_further_bps_, which always
happens with the first pair of probes. As result it wasn't sending
repeated probes as it should. This change fixes that issue by moving
probe expieration logic to ProbeContoller::Process(). This also ensures
that the controller goes to kProbingComplete state as soon as probing
timeout expired, without waiting for the next SetEstimatedBitrate()
call.

BUG=669421
Committed: https://crrev.com/9cef11b75e5173cef3995155f5de80f8710fccae
Cr-Commit-Position: refs/heads/master@{#15392}

[Sergey Ulanov, 2016-12-01 01:02:42]

sergeyu@chromium.org changed reviewers:
+ philipel@webrtc.org, stefan@webrtc.org

[philipel, 2016-12-01 09:21:37]

lgtm

[philipel, 2016-12-02 12:35:51]

Just realized, it would be good if we added a unittest that test this behavior.

[stefan-webrtc, 2016-12-02 12:41:17]

lgtm % test added as philip suggests

[Sergey Ulanov, 2016-12-02 18:38:03]

On 2016/12/02 12:41:17, stefan-webrtc (holmer) wrote:
> lgtm % test added as philip suggests

There is ProbeControllerTest.TestExponentialProbing for exponential probing and
I updated it so that it will catch this bug in the future.

[Sergey Ulanov, 2016-12-02 18:38:10]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-12-02 18:38:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 19:03:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480703890853280, "parent_rev":
"1329a351f3b36dd53a698381394b5ffff7cdb85b", "commit_rev":
"eab0aadcf62a5f70f0e9e1b13eea01b1aa8c95b8"}

[commit-bot: I haz the power, 2016-12-02 19:03:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-02 19:03:15]

Description was changed from

==========
Fix exponential probing in ProbeController.

https://codereview.webrtc.org/2504023002 broke exponential probing.
After that change ProbeController stops exponential probes prematurely:
it goes to kProbingComplete state if SetEstimatedBitrate() is called
with bitrate lower than min_bitrate_to_probe_further_bps_, which always
happens with the first pair of probes. As result it wasn't sending
repeated probes as it should. This change fixes that issue by moving
probe expieration logic to ProbeContoller::Process(). This also ensures
that the controller goes to kProbingComplete state as soon as probing
timeout expired, without waiting for the next SetEstimatedBitrate()
call.

BUG=669421
==========

to

==========
Fix exponential probing in ProbeController.

https://codereview.webrtc.org/2504023002 broke exponential probing.
After that change ProbeController stops exponential probes prematurely:
it goes to kProbingComplete state if SetEstimatedBitrate() is called
with bitrate lower than min_bitrate_to_probe_further_bps_, which always
happens with the first pair of probes. As result it wasn't sending
repeated probes as it should. This change fixes that issue by moving
probe expieration logic to ProbeContoller::Process(). This also ensures
that the controller goes to kProbingComplete state as soon as probing
timeout expired, without waiting for the next SetEstimatedBitrate()
call.

BUG=669421

Committed: https://crrev.com/9cef11b75e5173cef3995155f5de80f8710fccae
Cr-Commit-Position: refs/heads/master@{#15392}
==========

[commit-bot: I haz the power, 2016-12-02 19:03:16]

Patchset 1 (id:??) landed as
https://crrev.com/9cef11b75e5173cef3995155f5de80f8710fccae
Cr-Commit-Position: refs/heads/master@{#15392}