Update smoothed bitrate.

webrtc/audio/audio_send_stream.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 209 matching lines @@
 }
 
 bool AudioSendStream::DeliverRtcp(const uint8_t* packet, size_t length) {
   // TODO(solenberg): Tests call this function on a network thread, libjingle
   // calls on the worker thread. We should move towards always using a network
   // thread. Then this check can be enabled.
   // RTC_DCHECK(!thread_checker_.CalledOnValidThread());
   return channel_proxy_->ReceivedRTCPPacket(packet, length);
 }
 
 uint32_t AudioSendStream::OnBitrateUpdated(uint32_t bitrate_bps,

[the sun, 2016/12/01 09:16:55]

If we can't 
RTC_DCHECK(thread_checker_.CalledOnValidThread());
please document what thread(s) we expect this method runs on.

[michaelt, 2016/12/05 15:08:49]

OnBitrateUpdated is called on the worker queue. 
https://cs.chromium.org/chromium/src/third_party/webrtc/base/task_queue.h?q=r...
Since TaskQueue don't guarantee to be called on the same thread,  a
thread_checker may fail.

I could check if the function is called on the worker queue.

                                            uint8_t fraction_loss,
                                            int64_t rtt) {
   RTC_DCHECK_GE(bitrate_bps,
                 static_cast<uint32_t>(config_.min_bitrate_bps));
   // The bitrate allocator might allocate an higher than max configured bitrate
   // if there is room, to allow for, as example, extra FEC. Ignore that for now.
   const uint32_t max_bitrate_bps = config_.max_bitrate_bps;
   if (bitrate_bps > max_bitrate_bps)
     bitrate_bps = max_bitrate_bps;
 
   channel_proxy_->SetBitrate(bitrate_bps);
 
+  if (first_update_bitrate_())

[the sun, 2016/12/01 09:16:55]

nit: always {} in this file, even for one-liners

[michaelt, 2016/12/05 15:08:49]

Done.

+    UpdateSmoothedBitrate();
   // The amount of audio protection is not exposed by the encoder, hence
   // always returning 0.
   return 0;
 }
 
 const webrtc::AudioSendStream::Config& AudioSendStream::config() const {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   return config_;
 }
 
@@ skipping 122 matching lines @@
       // interaction between VAD and Opus FEC.
       if (codec->SetVADStatus(channel, true) != 0) {
         LOG(LS_WARNING) << "SetVADStatus() failed: " << base->LastError();
         return false;
       }
     }
   }
   return true;
 }
 
+void AudioSendStream::UpdateSmoothedBitrate() {
+  channel_proxy_->UpdateSmoothedBitrate();
+  constexpr uint32_t kUpdateSmoothedBitrateIntervalMs = 200;
+  worker_queue_->PostDelayedTask([this]() { UpdateSmoothedBitrate(); },
+                                 kUpdateSmoothedBitrateIntervalMs);
+}
+
 }  // namespace internal
 }  // namespace webrtc