Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: webrtc/media/base/codec.h

Issue 2546363002: Refactoring: Declare cricket::Codec constructors protected. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/webrtcsdp.cc ('k') | webrtc/media/base/codec_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/codec.h
diff --git a/webrtc/media/base/codec.h b/webrtc/media/base/codec.h
index 85b4327bb5cb61dd7ef67fbc868ea39c8905b63c..123d4fd2884c69d5e4cea55693f4fb164d9b5ba4 100644
--- a/webrtc/media/base/codec.h
+++ b/webrtc/media/base/codec.h
@@ -67,12 +67,6 @@ struct Codec {
CodecParameterMap params;
FeedbackParams feedback_params;
- // Creates a codec with the given parameters.
- Codec(int id, const std::string& name, int clockrate);
- // Creates an empty codec.
- Codec();
- Codec(const Codec& c);
- Codec(Codec&& c);
virtual ~Codec();
// Indicates if this codec is compatible with the specified codec.
@@ -106,6 +100,15 @@ struct Codec {
bool operator!=(const Codec& c) const {
return !(*this == c);
}
+
+ protected:
+ // A Codec can't be created without a subclass.
+ // Creates a codec with the given parameters.
+ Codec(int id, const std::string& name, int clockrate);
+ // Creates an empty codec.
+ Codec();
+ Codec(const Codec& c);
+ Codec(Codec&& c);
};
struct AudioCodec : public Codec {
« no previous file with comments | « webrtc/api/webrtcsdp.cc ('k') | webrtc/media/base/codec_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698